-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Freeze into Develop #1024
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge Develop into Freeze
Use a copy of the internal library element for reconciling to avoid affecting the current resource during save. Also perform a simple load instead of a full reparse, which would unnecessarily unload and clear the internal library element. Further, catch and wrap exceptions that may occur during reconciling.
If a comment contained the special characters '$' or '\', those were interpreted as group references or escapes when performing replacements. This directly assembles the result from macthes, thus avoiding looking for special escape sequences in replacement strings in the first place.
Co-authored-by: Martin Jobst <martin.jobst@posteo.de>
The deployment process was using the job state to determine whether it was terminated. This also meant that it considered itself terminated for a short time before the job was scheduled during launch. If the corresponding process console was initialized during that time, it then prematurely closed its streams, leading to no output in the console. This uses a separate flag to determine the terminated state, which is set only after the job is done.
Fix unnecessary dependencies and unnecessary parsing for internal attributes and missing dependencies for initial values.
ernstblechaPT
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.