Fix remote function calls in evaluator #939
Open
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log exceptions in evaluator process to aid in debugging problems related to evaluator execution.
Catch all exceptions when closing shared resources in evaluator to ensure proper termination regardless of exceptions in any of the shared resources.
The call to prepare the evaluator needs to be before resolving the instance event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix NPE in deployment FB evaluator when not already prepared, which can happen for certain remote function calls (i.e., executing functions on FORTE). Also catch all exceptions when closing shared resources in evaluator to ensure proper termination regardless of exceptions in any of the shared resources. Also log exceptions in evaluator process to aid in debugging problems related to evaluator execution.