-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling of multiple Concept Descriptions #138
Merged
FrankSchnicke
merged 14 commits into
eclipse-basyx:main
from
seicke:handle-multiple-concept-descriptions
Jun 3, 2024
Merged
Handling of multiple Concept Descriptions #138
FrankSchnicke
merged 14 commits into
eclipse-basyx:main
from
seicke:handle-multiple-concept-descriptions
Jun 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(hard to determine the "correct" dataSpecificationContent.definition from multiple EmbeddedDataSpecifications of multiple ConceptDescriptions Also comment out not used SubmodelElementWrapper.vue
seicke
commented
May 17, 2024
aas-gui/Frontend/aas-web-gui/src/components/SubmodelPlugins/TimeSeriesData.vue
Outdated
Show resolved
Hide resolved
aaronzi
requested changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution to support multiple ConceptDescriptions
aas-gui/Frontend/aas-web-gui/src/components/SubmodelElements/Range.vue
Outdated
Show resolved
Hide resolved
aas-gui/Frontend/aas-web-gui/src/components/SubmodelElements/ValueTypes/DateTimeStampType.vue
Outdated
Show resolved
Hide resolved
aas-gui/Frontend/aas-web-gui/src/components/SubmodelElements/ValueTypes/NumberType.vue
Outdated
Show resolved
Hide resolved
aas-gui/Frontend/aas-web-gui/src/components/Widgets/DisplayField.vue
Outdated
Show resolved
Hide resolved
aas-gui/Frontend/aas-web-gui/src/mixins/SubmodelElementHandling.ts
Outdated
Show resolved
Hide resolved
aas-gui/Frontend/aas-web-gui/src/components/SubmodelElementView.vue
Outdated
Show resolved
Hide resolved
aaronzi
requested changes
May 30, 2024
aas-gui/Frontend/aas-web-gui/src/components/SubmodelElementView.vue
Outdated
Show resolved
Hide resolved
aas-gui/Frontend/aas-web-gui/src/components/SubmodelPlugins/DigitalNameplate.vue
Outdated
Show resolved
Hide resolved
aas-gui/Frontend/aas-web-gui/src/components/SubmodelPlugins/DigitalNameplate.vue
Outdated
Show resolved
Hide resolved
aas-gui/Frontend/aas-web-gui/src/components/SubmodelPlugins/DigitalNameplate.vue
Outdated
Show resolved
Hide resolved
aas-gui/Frontend/aas-web-gui/src/components/SubmodelPlugins/DigitalNameplate.vue
Outdated
Show resolved
Hide resolved
aas-gui/Frontend/aas-web-gui/src/components/SubmodelPlugins/DigitalNameplate.vue
Show resolved
Hide resolved
aas-gui/Frontend/aas-web-gui/src/components/UIComponents/SubmodelElementWrapper.vue
Outdated
Show resolved
Hide resolved
aas-gui/Frontend/aas-web-gui/src/components/UIComponents/SubmodelElementWrapper.vue
Outdated
Show resolved
Hide resolved
aas-gui/Frontend/aas-web-gui/src/components/UIComponents/SubmodelElementWrapper.vue
Show resolved
Hide resolved
aas-gui/Frontend/aas-web-gui/src/mixins/SubmodelElementHandling.ts
Outdated
Show resolved
Hide resolved
aaronzi
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Aaron,
I have noticed that the aas-gui handles just the first SemanticId of a SM/SME:
basyx-applications/aas-gui/Frontend/aas-web-gui/src/mixins/SubmodelElementHandling.ts
Line 409 in 543972c