Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of multiple Concept Descriptions #138

Merged
merged 14 commits into from
Jun 3, 2024
Merged

Handling of multiple Concept Descriptions #138

merged 14 commits into from
Jun 3, 2024

Conversation

seicke
Copy link
Member

@seicke seicke commented May 17, 2024

Dear Aaron,

I have noticed that the aas-gui handles just the first SemanticId of a SM/SME:

let path = conceptDescriptionRepoURL + "/" + this.URLEncode(SelectedNode.semanticId.keys[0].value);

@seicke
Copy link
Member Author

seicke commented May 17, 2024

Fix display of SemanticIds:

Before:
before

After:
after

seicke added 2 commits May 17, 2024 15:45
(hard to determine the "correct" dataSpecificationContent.definition from multiple EmbeddedDataSpecifications of multiple ConceptDescriptions

Also comment out not used SubmodelElementWrapper.vue
Copy link
Member

@aaronzi aaronzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution to support multiple ConceptDescriptions

@seicke
Copy link
Member Author

seicke commented May 22, 2024

Fix display of empty ConceptDescription:
Before:
Bildschirmfoto 2024-05-22 um 11 22 32

After:
Bildschirmfoto 2024-05-22 um 11 23 02

@seicke seicke marked this pull request as ready for review May 27, 2024 12:43
@FrankSchnicke FrankSchnicke merged commit 3e71e38 into eclipse-basyx:main Jun 3, 2024
2 checks passed
@seicke seicke deleted the handle-multiple-concept-descriptions branch August 28, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants