basyx: add compliance-tool with git history #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AdministrationShell
json: update to schema 2.0.1 See merge request acplt/pyaas!22
Re-publish reader/writer functions and relevant classes from adapter.json and adapter.xml modules. Rename read_json_aas_file to read_aas_json_file. Change json and xml module imports accordingly. Close eclipse-basyx#65
adapter: re-publish reader/writer functions Closes eclipse-basyx#65 See merge request acplt/pyaas!23
add set_copyright_year.sh script to etc/scripts
adapter.xml.xml_serialization: Remove attribute "xsi:type" from element "value" in _value_to_xml adapter.xml.xml_serialization: Add wrapping <submodelElement> around statements in entity_to_xml adapter.xml.xml_deserialization: add parsing submodelElement wrapper to _construct_entity and _construct_submodel_element_collection
We extract the compliance_tool into its own package, since the functionality is not needed in the general SDK anymore. This commit moves the existing files to their new locations.
Previously, the schema checks for JSON were failing due to this missing requirement.
This commit adds `.aasx` to the `.gitignore`, since we want to dynamically create the AASX files during runtime of the unittests, rather than committing them to the repository
Previously, the BaSyx-Python AASX reader returned a "File not found" exception, when an AASX-file could not be found. However, now it appears that it returns `is not a valid ECMA376-2 (OPC) file` instead. We update the unittest to reflect this change.
The mypy call in `.github/workflows/ci.yml` was outdated with the compliance tool extraction. This is fixed here.
Add a missing white line
Previously, we used the old GitHub secrets method to publish to PyPI. However, this method appears to be outdated. Follwing [this guide], we update the .github Release workflow [this guide](https://docs.pypi.org/trusted-publishers/using-a-publisher/)
…ce-tool Add compliance-tool to basyx-python-sdk.
|
Looks like the Maybe we should only call mypy once in the entire CI and specify each module to call it on explicitly? |
|
It looks to me like Torben needs to connect his email torben.deppe@p*t.rwth-aachen.de with an Eclipse certificate so we can merge this branch later. |
|
I don't think this is necessary (or possible for that matter), since the compliance tool has existed in this repository with this exact history before. We will just document this here in the PR text, when we get ready to close it. |
|
Let's wait with this until #332 is closed, fix the conflicts once and then merge. Other than the CI conflicts, this LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the content and git history of https://github.com/rwth-iat/aas-compliance-tool under the folder basyx.
Fixes #277