Use dir() instead of vars() in Referable.update_from()
#338
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vars() only retrieves the instance's
dict—that is, the object's
attributes—but does not include
properties.
As a result, when you use vars(other),
you get the _id_short attribute instead
of the id_short property.
dir() iterates over all attributes and
properties of the object.
We skip callables and private attrs.
We use setattr() to set attributes and
properties, so setter funcs will be
used.
Fixes #215