Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

basyx.provider: Add SetObjectStore to provider #340

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

basyx.provider: Add SetObjectStore to provider #340

wants to merge 1 commit into from

Conversation

zrgt
Copy link
Contributor

@zrgt zrgt commented Nov 21, 2024

SetObjectStore is backed by a set.
It does not have a problem with not updated ids as DictObjectStore (See #216).

I suppose the DictObjectStore or SetObjectStore normally do not contain so many Identifiables,
that iteration becomes a perfomance issue.

@zrgt
Add SetObjectStore to provider
139d8e4 
SetObjectStore is backed by a set.
It does not have a problem with
not updated ids as DictObjectStore (See eclipse-basyx#216).
@Frosty2500
Copy link
Contributor

LGTM 👍

@s-heppner
Copy link
Contributor

The code LGTM, but what's the use case for a SetObjectStore?

@s-heppner
Copy link
Contributor

As discussed in our meeting, both DictObjectStore and SetObjectStore have their advantages and disadvantages.
We document these in the docstrings of the classes and provide both in the future.

@s-heppner s-heppner changed the base branch from main to develop January 14, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zrgt @Frosty2500 @s-heppner