-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scripts.set_copyright_year: Add a CI check to ensure the copyright is updated #344
scripts.set_copyright_year: Add a CI check to ensure the copyright is updated #344
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than that minor comment, it lgtm.
It looks to me like there are a lot of false import statements causing errors in the |
No, I do not know that. Could you maybe investigate? |
It seems to be a bigger problem. Even when I fix the imports the unitests fail. There seems to be quite some code that needs to be changed. I will create an issue and a seperate pull request, till this is fixed we can basically ignore the ci tests for the |
d683a27
to
37f5a3e
Compare
a8e5a10
to
37f5a3e
Compare
Co-authored-by: s-heppner <s.heppner@plt.rwth-aachen.de>
37f5a3e
to
1374cdb
Compare
9d030b3
to
07caf10
Compare
Currently we do not check if every copyright is up to date.
Now the ci pipeline will fail if the copyright is not up to date in some files.
Fixes #260
Fixes #331