Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The preview does not work anymore: #1901 #1904

Merged
merged 1 commit into from
Sep 12, 2024
Merged

The preview does not work anymore: #1901 #1904

merged 1 commit into from
Sep 12, 2024

Conversation

wimjongman
Copy link
Contributor

After switching the default browser to Edge in issues #1736 and #1737 the preview pane was broken because Edge does not like plain filenames.

Fixed:

  1. Convert the plain file name to a file URL

This also fixed:

@wimjongman wimjongman added this to the 4.17 milestone Sep 11, 2024
This was linked to issues Sep 11, 2024
The preview does not work anymore: #1901
Closed
Ask to save the editor when it is dirty and Preview is requested. #1902
Closed
New Preview Prototype tab must be called Preview #1903
Closed
merks
merks approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Indeed best to use a proper URL!

@speckyspooky
Copy link
Contributor

@wimjongman
I checked the changes an I have only a small question to the new message dialog - see comment.
Do you know which developer implements the "preview, prototype"?
I like the idea but the element support is not given over all elements and it would be good to know if there are changes upcoming.

@speckyspooky speckyspooky added Enhancement Small change to improve the current supported functionality BugFix Change to correct issues labels Sep 12, 2024
@wimjongman
The preview does not work anymore: #1901
037ccbf 
After switching the default browser to Edge in issues #1736 and #1737
the preview pane was broken because Edge does not like plain filenames.

Fixed:

1. Convert the plain file name to a file URL

This also fixed:

* Ask to save the editor when it is dirty and Preview is
requested. #1902
* 'New Preview Prototype' tab must be called Preview #1903
@wimjongman wimjongman force-pushed the The_preview_does_not_work_anymore_#1901 branch from 3c462d4 to 037ccbf Compare September 12, 2024 10:25
@wimjongman
Copy link
Contributor Author

@wimjongman Do you know which developer implements the "preview, prototype"? I like the idea but the element support is not given over all elements and it would be good to know if there are changes upcoming.

Please file an issue for additional requirements and explain what you mean. The original developer is unknown.

@speckyspooky
Copy link
Contributor

Of course, with the preview we have a half solution of it in compare to the web-preview (e.g. parameter display, images, etc.).
And at the end yes, ask the original developer if it is possible to add there some details that it can be used in a good way.

I work with lot of reports with dynamic parameters and images. But the "preview" is not helpful with the unsupported parts.

@wimjongman
Copy link
Contributor Author

It processes parameters but no Image. It is weird because it should show the rendered html page. Please file an issue for it.

image

@wimjongman wimjongman merged commit aa849c4 into master Sep 12, 2024
3 checks passed
@merks
Copy link
Contributor

merks commented Sep 13, 2024

@wimjongman

FYI, you've been pushing branches to the main repository instead of to your clone again:

image

And not deleting it when done.

@merks merks deleted the The_preview_does_not_work_anymore_#1901 branch September 13, 2024 06:33
@wimjongman
Copy link
Contributor Author

Consider the environment before creating a fork! ;)

I merged through the Github app and that did not delete the branch. It won't happen again. 😞

@merks
Copy link
Contributor

merks commented Sep 13, 2024

It's not a big deal. Just a small deal. 👅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@speckyspooky speckyspooky speckyspooky approved these changes

@merks merks merks approved these changes

Assignees

@wimjongman wimjongman

Labels
BugFix Change to correct issues Enhancement Small change to improve the current supported functionality
Projects
None yet
Milestone
4.17
3 participants
@wimjongman @speckyspooky @merks