Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization of docx emitter output (#1957) #1958

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Optimization of docx emitter output (#1957) #1958

merged 2 commits into from
Nov 6, 2024

Conversation

speckyspooky
Copy link
Contributor

No description provided.

@speckyspooky speckyspooky added this to the 4.18 milestone Nov 4, 2024
@speckyspooky speckyspooky self-assigned this Nov 4, 2024
wimjongman
wimjongman requested changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@wimjongman wimjongman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review ready.

...ort.engine.emitter.docx/src/org/eclipse/birt/report/engine/emitter/docx/DocxEmitterImpl.java Show resolved Hide resolved
...gine.emitter.docx/src/org/eclipse/birt/report/engine/emitter/docx/writer/BasicComponent.java Show resolved Hide resolved
...ort.engine.emitter.wpml/src/org/eclipse/birt/report/engine/emitter/wpml/EmitterServices.java Show resolved Hide resolved
...ort.engine.emitter.wpml/src/org/eclipse/birt/report/engine/emitter/wpml/EmitterServices.java Show resolved Hide resolved
...ort.engine.emitter.wpml/src/org/eclipse/birt/report/engine/emitter/wpml/EmitterServices.java Show resolved Hide resolved
@speckyspooky
Copy link
Contributor Author

@wimjongman
Hi Wim, could you be so kind for the re-validation of my update and comments.
I will start with further changes and will avoid a mixture of these changes and upcoming changes (from my side).
So it would be good to get your "go" or "request of further changes".

wimjongman
wimjongman approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@wimjongman wimjongman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thanks, Thomas!

@wimjongman wimjongman merged commit 29525b6 into eclipse-birt:master Nov 6, 2024
3 of 5 checks passed
@speckyspooky speckyspooky mentioned this pull request Nov 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wimjongman wimjongman wimjongman approved these changes

Assignees

@speckyspooky speckyspooky

Labels
Feature
Projects
None yet
Milestone
4.18
Development

Successfully merging this pull request may close these issues.
2 participants
@speckyspooky @wimjongman