Fix cursor behavior in memory view on HiDPI (#645)

Cursor not behaving correctly in memory view editor while chaging variable value on Hi-DPI #641 Used GC.textExtent() method for getting width of a character as it handles zooming factor Fixes #641
eclipse-cdt · Dec 27, 2023 · 93c136d · 93c136d
1 parent 533125c
commit 93c136d
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/memory/org.eclipse.cdt.debug.ui.memory.floatingpoint/META-INF/MANIFEST.MF b/memory/org.eclipse.cdt.debug.ui.memory.floatingpoint/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.cdt.debug.ui.memory.floatingpoint;singleton:=true
-Bundle-Version: 1.2.0.qualifier
+Bundle-Version: 1.2.100.qualifier
 Bundle-Localization: plugin
 Require-Bundle: org.eclipse.debug.core;bundle-version="3.7.100",
  org.eclipse.debug.ui;bundle-version="3.8.1",

diff --git a/...emory.floatingpoint/src/org/eclipse/cdt/debug/ui/memory/floatingpoint/FPAbstractPane.java b/...emory.floatingpoint/src/org/eclipse/cdt/debug/ui/memory/floatingpoint/FPAbstractPane.java
@@ -774,7 +774,7 @@ protected int getCellCharacterWidth() {
 		if (fCharacterWidth == -1) {
 			GC gc = new GC(this);
 			gc.setFont(fRendering.getFont());
-			fCharacterWidth = gc.getAdvanceWidth('F');
+			fCharacterWidth = gc.textExtent("F").x; //$NON-NLS-1$
 			gc.dispose();
 		}
 

diff --git a/memory/org.eclipse.cdt.debug.ui.memory.traditional/META-INF/MANIFEST.MF b/memory/org.eclipse.cdt.debug.ui.memory.traditional/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.cdt.debug.ui.memory.traditional;singleton:=true
-Bundle-Version: 1.7.0.qualifier
+Bundle-Version: 1.7.100.qualifier
 Bundle-Localization: plugin
 Require-Bundle: org.eclipse.debug.core,
  org.eclipse.debug.ui,

diff --git a/...g.ui.memory.traditional/src/org/eclipse/cdt/debug/ui/memory/traditional/AbstractPane.java b/...g.ui.memory.traditional/src/org/eclipse/cdt/debug/ui/memory/traditional/AbstractPane.java
@@ -742,7 +742,7 @@ protected int getCellCharacterWidth() {
 		if (fCharacterWidth == -1) {
 			GC gc = new GC(this);
 			gc.setFont(fRendering.getFont());
-			fCharacterWidth = gc.getAdvanceWidth('F');
+			fCharacterWidth = gc.textExtent("F").x; //$NON-NLS-1$
 			gc.dispose();
 		}
 

diff --git a/...debug.ui.memory.traditional/src/org/eclipse/cdt/debug/ui/memory/traditional/TextPane.java b/...debug.ui.memory.traditional/src/org/eclipse/cdt/debug/ui/memory/traditional/TextPane.java
@@ -79,7 +79,7 @@ protected void editCell(BigInteger address, int subCellPosition, char character)
 	protected int getCellWidth() {
 		GC gc = new GC(this);
 		gc.setFont(fRendering.getFont());
-		int width = gc.getAdvanceWidth('F');
+		int width = gc.textExtent("F").x; //$NON-NLS-1$
 		gc.dispose();
 
 		return fRendering.getBytesPerColumn() / fRendering.getBytesPerCharacter() * width;