Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Refresh Action to Command/Handler framework and support visibility only whne CDT debug is active. #1035

Closed
wants to merge 1 commit into from
Closed

Migrate Refresh Action to Command/Handler framework and support visibility only whne CDT debug is active. #1035

wants to merge 1 commit into from

Conversation

raghucssit
Copy link
Contributor

See #1034

@iloveeclipse
Copy link
Contributor 

Error: This request has been automatically failed because it uses a deprecated version of `actions/upload-artifact: v3`. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

@raghucssit : are you on top of master branch?

@jonahgraham
Copy link
Member

Error: This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v3. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

I recently did an update, it looks like I missed one place :-( Fix coming vert soon.

@jonahgraham
Copy link
Member

I recently did an update, it looks like I missed one place :-( Fix coming vert soon.

See #1036 and please rebase once I merge that.

@jonahgraham
Copy link
Member

License checking is failing, probably because a bunch of IT is down at EF https://www.eclipsestatus.io/incident/496975?mp=true

@raghucssit raghucssit force-pushed the refresh_action_migration_1034 branch from cf59513 to f3c802a Compare January 16, 2025 15:57
@jonahgraham
Copy link
Member

The IT outage means ECA can't pass so nothing can be merged:
image - you can ignore that failure/pending for now and we will revisit it when we IT comes back to life.

@raghucssit
Copy link
Contributor Author 

Error: This request has been automatically failed because it uses a deprecated version of `actions/upload-artifact: v3`. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

@raghucssit : are you on top of master branch?

yes.

@jonahgraham jonahgraham mentioned this pull request Jan 16, 2025
Merged
@raghucssit
Copy link
Contributor Author

raghucssit commented Jan 16, 2025 •
edited
Loading

I have cherry-picked 1036. Now build should go through.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2025 •
edited
Loading

Test Results

   635 files  ±0     635 suites  ±0   55m 11s ⏱️ -4s
11 417 tests ±0  11 206 ✅ ±0  143 💤 ±0  60 ❌ ±0  8 🔥 ±0 
11 455 runs  ±0  11 244 ✅ ±0  143 💤 ±0  60 ❌ ±0  8 🔥 ±0 

For more details on these failures and errors, see this check.

Results for commit e381b41. ± Comparison against base commit 8d06425.

♻️ This comment has been updated with latest results.

@jonahgraham
Copy link
Member

This pull request removes 121 tests.

This is the same thing happening on #1033. It isn't related to this change, but I don't know why it is failing yet.

@raghucssit
Copy link
Contributor Author

Some error thrown at dsf gbd tests after that no other tests are executed.

2025-01-16T16:41:44.0644358Z [INFO] org.eclipse.cdt.tests.dsf.gdb 2.3.100-SNAPSHOT ..... FAILURE [  8.004 s]
2025-01-16T16:41:44.0645257Z [INFO] [test-bundle] DSF-GDB multicorevisualizer test fragment 1.0.0-SNAPSHOT SKIPPED
2025-01-16T16:41:44.0646155Z [INFO] org.eclipse.cdt.debug.gdbjtag.core.tests 1.0.400-SNAPSHOT SKIPPED
2025-01-16T16:41:44.0646917Z [INFO] [test-bundle] Debug Core Memory Tests 0.1.0-SNAPSHOT SKIPPED
2025-01-16T16:41:44.0647777Z [INFO] [test-bundle] C/C++ Development Tools Tests Running Support Tests 1.0.0-SNAPSHOT SKIPPED
2025-01-16T16:41:44.0648634Z [INFO] org.eclipse.cdt.testing 8.1.500-SNAPSHOT ........... SKIPPED
2025-01-16T16:41:44.0649335Z [INFO] org.eclipse.cdt.testing 12.0.0-SNAPSHOT ............ SKIPPED
2025-01-16T16:41:44.0650040Z [INFO] org.eclipse.cdt.testing.repo 8.3.0-SNAPSHOT ........ SKIPPED
2025-01-16T16:41:44.0650728Z [INFO] ------------------------------------------------------------------------
2025-01-16T16:41:44.0651263Z [INFO] BUILD FAILURE
2025-01-16T16:41:44.0651713Z [INFO] ------------------------------------------------------------------------
2025-01-16T16:41:44.0652254Z [INFO] Total time:  21:50 min
2025-01-16T16:41:44.0652639Z [INFO] Finished at: 2025-01-16T16:41:44Z
2025-01-16T16:41:44.0653368Z [INFO] ------------------------------------------------------------------------
2025-01-16T16:41:44.1523155Z [ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:4.0.10:test (default-test) on project org.eclipse.cdt.tests.dsf.gdb: An unexpected error occurred while launching the test runtime (process returned error code 13).

This was referenced Jan 16, 2025
Merged
Closed
@jonahgraham
Copy link
Member

Some error thrown at dsf gbd tests after that no other tests are executed.

I raised #1037 to track this new problem.

@raghucssit raghucssit force-pushed the refresh_action_migration_1034 branch from 9ba693a to 10b0148 Compare January 16, 2025 20:25
@raghucssit raghucssit force-pushed the refresh_action_migration_1034 branch from 10b0148 to e381b41 Compare January 16, 2025 20:32
@raghucssit
Copy link
Contributor Author

Fixed all review comments. Rebase done on main. Let's see test results.

@raghucssit
Copy link
Contributor Author

Build is ok.
Except known failures #866

iloveeclipse
iloveeclipse reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@iloveeclipse iloveeclipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I haven't verified in debugger

@jonahgraham
Copy link
Member

Please see #1034 (comment) for why closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iloveeclipse iloveeclipse iloveeclipse left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raghucssit @iloveeclipse @jonahgraham