Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#657] CDT cannot be built on Java 21 due to security manager changes #761

Merged
merged 1 commit into from
Apr 19, 2024
Merged

[#657] CDT cannot be built on Java 21 due to security manager changes #761

merged 1 commit into from
Apr 19, 2024

Conversation

ruspl-afed
Copy link
Member

@ruspl-afed ruspl-afed commented Apr 19, 2024 •
edited
Loading

  • Switch CI to Java 21
  • Remove config generation for debug application
  • Remove org.eclipse.osgi.services from proxy.server product
  • Remove org.eclipse.osgi.services from
    org.eclipse.cdt.debug.application.product product
  • Move org.eclipse.cdt.debug.application.product from profile to
    general part

Fixed #657

@ruspl-afed ruspl-afed force-pushed the 657 branch 3 times, most recently from 49806ee to 5db917a Compare April 19, 2024 15:39
@ruspl-afed ruspl-afed mentioned this pull request Apr 19, 2024
Closed
@ruspl-afed
Copy link
Member Author

What if we include debug/org.eclipse.cdt.debug.application.product back to the general modules list @jonahgraham ?

Currently it is outside of the CI control.

@ruspl-afed
[eclipse-cdt#657] CDT cannot be built on Java 21 due to security mana…
8ca3c14 
…ger changes

* Switch CI to Java 21
* Remove config generation for debug application
* Remove `org.eclipse.osgi.services` from `proxy.server` product
* Remove `org.eclipse.osgi.services` from
`org.eclipse.cdt.debug.application.product` product
* Move `org.eclipse.cdt.debug.application.product` from profile to
general part

Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
@ruspl-afed
Copy link
Member Author

Well, no idea if Debug RCP is fully functional, but it starts after building locally from this branch
image

@ruspl-afed
Copy link
Member Author

testIncludeSource_Bug199412 (org.eclipse.cdt.internal.index.tests.IndexBugsTests) with error

We have 1 test failure that looks unrelated

@ruspl-afed
Copy link
Member Author

Merging this one to unblock further development in main branch

@ruspl-afed ruspl-afed merged commit 88355ec into eclipse-cdt:main Apr 19, 2024
4 of 5 checks passed
@jonahgraham
Copy link
Member

What if we include debug/org.eclipse.cdt.debug.application.product back to the general modules list @jonahgraham ?

Currently it is outside of the CI control.

Sorry that I missed this before. It was in its own profile because it is so fragile that it comes in and out of the main build regularly.

Remove config generation for debug application

I don't understand how debug application works if this is removed? The install script won't be able to find the config.ini:

cdt/debug/org.eclipse.cdt.debug.application/scripts/install.sh

Line 44 in 2c3f111

cp "$SCRIPT_DIR/config.ini" "$HOME/cdtdebugger"

The screenshot you took in #761 (comment) - how was that created? Was it with https://github.com/eclipse-cdt/cdt/blob/main/StandaloneDebugger.md

I'm about to raise an issue on standalone debugger and will cross reference this issue. Frankly I think my proposal is to remove it now or soon, so don't spend too much time addressing the above questions.

@jonahgraham jonahgraham mentioned this pull request May 10, 2024
Closed
jonahgraham added a commit to jonahgraham/cdt that referenced this pull request May 12, 2024
@jonahgraham
Change standalone debugger to no longer limit number of bundles
f628420 
The maintenance of having a streamlined standalone debugger that
starts as fast as possible is no longer possible. See for
example eclipse-cdt#591 - therefore when using standalone debugger, use
the same sets of plug-ins/features as the product it is installed
in uses. The side effect is that the standalone debugger in this
use case will start slower and extra "stuff" will be present in
this UI.

For people just building the standalone debugger, provide a minimum
feature set. This will be many more bundles than before, but
should still provide a reasonably small set that starts well.

This simplification also includes removing the the duplicates set
of CDT docs (debug/org.eclipse.cdt.debug.application.doc). These
provided a simplified version of CDT's documentation targetted
at just standalone debugger. However there are a few problems related
to this duplication:

- The two sets of docs were not kept in sync
- The standalone docs appear in the online help, leading to
  duplicated entries
- With the config.ini changes above, there is no way to exclude
  the main docs in the standalone case, so remove the duplicate

A number of directly related clean-ups are included too:

- Remove the `ConfigGenerator.java` that stopped being referenced
  in PR eclipse-cdt#761
- Complete the removal of `build-standalone-debugger-rcp` profile
  that was started in eclipse-cdt#761. There is a small drawback to not having
  this profile, the standalone debugger is very slow to build
  compared to the rest of CDT. If this becomes a problem, restoring
  this profile along with the changes made in eclipse-cdt#761 is reasonable.

Fixes eclipse-cdt#781

- bring debug.product's licenses up to date
- modernize command line args to eclipse when using debug.product
jonahgraham added a commit to jonahgraham/cdt that referenced this pull request May 12, 2024
@jonahgraham
Change standalone debugger to no longer limit number of bundles
1765f77 
The maintenance of having a streamlined standalone debugger that
starts as fast as possible is no longer possible. See for
example eclipse-cdt#591 - therefore when using standalone debugger, use
the same sets of plug-ins/features as the product it is installed
in uses. The side effect is that the standalone debugger in this
use case will start slower and extra "stuff" will be present in
this UI.

For people just building the standalone debugger, provide a minimum
feature set. This will be many more bundles than before, but
should still provide a reasonably small set that starts well.

This simplification also includes removing the the duplicates set
of CDT docs (debug/org.eclipse.cdt.debug.application.doc). These
provided a simplified version of CDT's documentation targetted
at just standalone debugger. However there are a few problems related
to this duplication:

- The two sets of docs were not kept in sync
- The standalone docs appear in the online help, leading to
  duplicated entries
- With the config.ini changes above, there is no way to exclude
  the main docs in the standalone case, so remove the duplicate

A number of directly related clean-ups are included too:

- Remove the `ConfigGenerator.java` that stopped being referenced
  in PR eclipse-cdt#761
- Complete the removal of `build-standalone-debugger-rcp` profile
  that was started in eclipse-cdt#761. There is a small drawback to not having
  this profile, the standalone debugger is very slow to build
  compared to the rest of CDT. If this becomes a problem, restoring
  this profile along with the changes made in eclipse-cdt#761 is reasonable.
- bring debug.product's licenses up to date
- modernize command line args to eclipse when using debug.product

Fixes eclipse-cdt#781
@jonahgraham jonahgraham mentioned this pull request May 12, 2024
Merged
jonahgraham added a commit to jonahgraham/cdt that referenced this pull request May 12, 2024
@jonahgraham
Change standalone debugger to no longer limit number of bundles
89667cd 
The maintenance of having a streamlined standalone debugger that
starts as fast as possible is no longer possible. See for
example eclipse-cdt#591 - therefore when using standalone debugger, use
the same sets of plug-ins/features as the product it is installed
in uses. The side effect is that the standalone debugger in this
use case will start slower and extra "stuff" will be present in
this UI.

For people just building the standalone debugger, provide a minimum
feature set. This will be many more bundles than before, but
should still provide a reasonably small set that starts well.

This simplification also includes removing the the duplicates set
of CDT docs (debug/org.eclipse.cdt.debug.application.doc). These
provided a simplified version of CDT's documentation targetted
at just standalone debugger. However there are a few problems related
to this duplication:

- The two sets of docs were not kept in sync
- The standalone docs appear in the online help, leading to
  duplicated entries
- With the config.ini changes above, there is no way to exclude
  the main docs in the standalone case, so remove the duplicate

A number of directly related clean-ups are included too:

- Remove the `ConfigGenerator.java` that stopped being referenced
  in PR eclipse-cdt#761
- Complete the removal of `build-standalone-debugger-rcp` profile
  that was started in eclipse-cdt#761. There is a small drawback to not having
  this profile, the standalone debugger is very slow to build
  compared to the rest of CDT. If this becomes a problem, restoring
  this profile along with the changes made in eclipse-cdt#761 is reasonable.
- bring debug.product's licenses up to date
- modernize command line args to eclipse when using debug.product

Fixes eclipse-cdt#781
jonahgraham added a commit to jonahgraham/cdt that referenced this pull request May 12, 2024
@jonahgraham
Change standalone debugger to no longer limit number of bundles
0568568 
The maintenance of having a streamlined standalone debugger that
starts as fast as possible is no longer possible. See for
example eclipse-cdt#591 - therefore when using standalone debugger, use
the same sets of plug-ins/features as the product it is installed
in uses. The side effect is that the standalone debugger in this
use case will start slower and extra "stuff" will be present in
this UI.

For people just building the standalone debugger, provide a minimum
feature set. This will be many more bundles than before, but
should still provide a reasonably small set that starts well.

This simplification also includes removing the the duplicates set
of CDT docs (debug/org.eclipse.cdt.debug.application.doc). These
provided a simplified version of CDT's documentation targetted
at just standalone debugger. However there are a few problems related
to this duplication:

- The two sets of docs were not kept in sync
- The standalone docs appear in the online help, leading to
  duplicated entries
- With the config.ini changes above, there is no way to exclude
  the main docs in the standalone case, so remove the duplicate

A number of directly related clean-ups are included too:

- Remove the `ConfigGenerator.java` that stopped being referenced
  in PR eclipse-cdt#761
- Complete the removal of `build-standalone-debugger-rcp` profile
  that was started in eclipse-cdt#761. There is a small drawback to not having
  this profile, the standalone debugger is very slow to build
  compared to the rest of CDT. If this becomes a problem, restoring
  this profile along with the changes made in eclipse-cdt#761 is reasonable.
- bring debug.product's licenses up to date
- modernize command line args to eclipse when using debug.product

Fixes eclipse-cdt#781
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CDT cannot be built on Java 21 due to security manager changes
2 participants
@ruspl-afed @jonahgraham