Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiler path in compile_commands.json must be absolute #824

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Compiler path in compile_commands.json must be absolute #824

merged 1 commit into from
Jul 31, 2024

Conversation

alicetrifu
Copy link
Contributor

Added code to create the absolute path of the compiler on compile_commands.json file
#822

@alicetrifu alicetrifu force-pushed the compilerPathLocation branch from f1253df to d4bace4 Compare June 13, 2024 13:24
@Kummallinen Kummallinen requested a review from jonahgraham June 17, 2024 13:07
jonahgraham
jonahgraham reviewed Jun 18, 2024
View reviewed changes
...eclipse/cdt/managedbuilder/internal/core/jsoncdb/generator/CompilationDatabaseGenerator.java Outdated Show resolved Hide resolved
...eclipse/cdt/managedbuilder/internal/core/jsoncdb/generator/CompilationDatabaseGenerator.java Outdated Show resolved Hide resolved
...eclipse/cdt/managedbuilder/internal/core/jsoncdb/generator/CompilationDatabaseGenerator.java Outdated Show resolved Hide resolved
...eclipse/cdt/managedbuilder/internal/core/jsoncdb/generator/CompilationDatabaseGenerator.java Show resolved Hide resolved
...eclipse/cdt/managedbuilder/internal/core/jsoncdb/generator/CompilationDatabaseGenerator.java Outdated Show resolved Hide resolved
...eclipse/cdt/managedbuilder/internal/core/jsoncdb/generator/CompilationDatabaseGenerator.java Outdated Show resolved Hide resolved
...eclipse/cdt/managedbuilder/internal/core/jsoncdb/generator/CompilationDatabaseGenerator.java Show resolved Hide resolved
@alicetrifu alicetrifu force-pushed the compilerPathLocation branch from d4bace4 to 6ce8ffb Compare June 19, 2024 14:28
jonahgraham
jonahgraham requested changes Jun 19, 2024
View reviewed changes
Copy link
Member

@jonahgraham jonahgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Please add some tests, can you cover cases when compiler is on the system PATH, but the project PATH points to a different one? I think that case is the most likely to regress as it is non-obvious to most developers.

...eclipse/cdt/managedbuilder/internal/core/jsoncdb/generator/CompilationDatabaseGenerator.java Outdated Show resolved Hide resolved
...eclipse/cdt/managedbuilder/internal/core/jsoncdb/generator/CompilationDatabaseGenerator.java Outdated Show resolved Hide resolved
...eclipse/cdt/managedbuilder/internal/core/jsoncdb/generator/CompilationDatabaseGenerator.java Outdated Show resolved Hide resolved
...eclipse/cdt/managedbuilder/internal/core/jsoncdb/generator/CompilationDatabaseGenerator.java Outdated Show resolved Hide resolved
@alicetrifu alicetrifu force-pushed the compilerPathLocation branch from 6ce8ffb to 50f908f Compare June 19, 2024 15:28
jonahgraham
jonahgraham requested changes Jun 19, 2024
View reviewed changes
Copy link
Member

@jonahgraham jonahgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alicetrifu for the updates - the code all looks ok now. Just the tests as we discussed from the last review.

@alicetrifu alicetrifu force-pushed the compilerPathLocation branch from 50f908f to 8910e03 Compare June 20, 2024 14:17
@alicetrifu alicetrifu force-pushed the compilerPathLocation branch from 8910e03 to 75fe7d7 Compare June 21, 2024 14:09
@alicetrifu alicetrifu force-pushed the compilerPathLocation branch from 75fe7d7 to f021eeb Compare June 21, 2024 14:50
@alicetrifu alicetrifu force-pushed the compilerPathLocation branch from f021eeb to 6b57b89 Compare July 1, 2024 07:18
@alicetrifu alicetrifu force-pushed the compilerPathLocation branch from 6b57b89 to 1ec8909 Compare July 3, 2024 07:13
jonahgraham
jonahgraham requested changes Jul 3, 2024
View reviewed changes
Copy link
Member

@jonahgraham jonahgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready to go, just noticed a minor nit about usage of JUnit. The test failure seems unrelated and I retriggered the build to verify that.

...tests/tests/org/eclipse/cdt/managedbuilder/core/tests/CompilationDatabaseGenerationTest.java Outdated Show resolved Hide resolved
@alicetrifu alicetrifu force-pushed the compilerPathLocation branch from 1ec8909 to 7f97fab Compare July 3, 2024 12:13
jonahgraham
jonahgraham approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@jonahgraham jonahgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once build reports a clean run this is good to go.

@jonahgraham jonahgraham linked an issue Jul 31, 2024 that may be closed by this pull request
Compiler path in compile_commands.json must be absolute #822
Closed
@jonahgraham jonahgraham merged commit 7420b12 into eclipse-cdt:main Jul 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahgraham jonahgraham jonahgraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiler path in compile_commands.json must be absolute
2 participants
@alicetrifu @jonahgraham