-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Description of the Core Build System. #960
Conversation
Hi @jonahgraham , @betamaxbandit , and @jld01 , |
9938836
to
80e1aae
Compare
doc/org.eclipse.cdt.doc.user/src/asciidoc/core_build_system.adoc
Outdated
Show resolved
Hide resolved
doc/org.eclipse.cdt.doc.user/src/asciidoc/core_build_system.adoc
Outdated
Show resolved
Hide resolved
doc/org.eclipse.cdt.doc.user/src/asciidoc/core_build_system.adoc
Outdated
Show resolved
Hide resolved
doc/org.eclipse.cdt.doc.user/src/asciidoc/core_build_system.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good intro/comparison @ewaterlander
I think one key difference to add to the list at the end is:
- Sharing projects with other IDEs. The Managed Build projects are proprietary to Eclipse CDT and requires Eclipse CDT to build (from UI or command line). CMake projects are an industry standard and many IDEs come with support for CMake. Therefore sharing projects with multiple people and using CMake is easier.
Some notes on the above, proprietary isn't the right word, but it is close. I also though that headless build was documented, but if it is I can't find it . I can thank our friend project embed-cdt which has documented it here
doc/org.eclipse.cdt.doc.user/src/asciidoc/core_build_system.adoc
Outdated
Show resolved
Hide resolved
I would say it looks more like Eclipse CDT "vendor lock". Yes, this is a problem, and many people don't like this. |
For us a big advantage is that with Core Build you can use the same (c)make flow for IDE users, command-line users, and nightly regressions. And the real showstopper for MBS was that it is not usable for multi-core systems. Building a GUI to set compiler flags for multiple binaries was not doable, or at least hard to do. People can easily live without makefile generation. The essential parts of the IDE are code navigation and debugging. |
Why so? One can use multiple projects (or multiple configuration that is less usable). |
It is possible to split into multiple MBS projects. I actually tried that, before I discovered Core Build. But that adds a lot of overhead. I work in a Linux-only environment, where command-line is still king. If I had to ask programmers to split their single Makefile projects, they would not use the IDE. |
Ah, this is to bring the lost back into the fold of the IDE. This is a good argument, I hope it will have an effect. |
Like Jonah already said, being able to share the project is a key difference. Not only with other IDEs, but also with command-line. We encourage people to use the IDE, but they are free to use command line, or both. If you're able to easily switch between IDE and command-line you can use the best of both worlds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - @jld01 if you are happy with the updated language (especially around removal of "old" and use of "legacy") then we are good to go here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
doc/org.eclipse.cdt.doc.user/src/asciidoc/core_build_system.adoc
Outdated
Show resolved
Hide resolved
doc/org.eclipse.cdt.doc.user/src/asciidoc/core_build_system.adoc
Outdated
Show resolved
Hide resolved
@ewaterlander thanks for the document. I have added some suggestions for consistency and flow. Let me know what you think. We also need to introduce the HTML file that will be generated at
in https://github.com/eclipse-cdt/cdt/blob/main/doc/org.eclipse.cdt.doc.user/topics_Getting_Started.xml |
I think your suggestions are addressed in the second commit. Did I miss something?
I will add it. |
I don't see where these comments are addressed. At present, the text seems to be in a conversational style. My suggested edits are intended to give the text more of a documentation style in keeping with the other help pages. I would prefer that these changes (or similar) be applied before merging. |
Let's talk about this in the meeting, because I don't see what I missed. And also about the style. |
doc/org.eclipse.cdt.doc.user/src/asciidoc/core_build_system.adoc
Outdated
Show resolved
Hide resolved
doc/org.eclipse.cdt.doc.user/src/asciidoc/core_build_system.adoc
Outdated
Show resolved
Hide resolved
doc/org.eclipse.cdt.doc.user/src/asciidoc/core_build_system.adoc
Outdated
Show resolved
Hide resolved
doc/org.eclipse.cdt.doc.user/src/asciidoc/core_build_system.adoc
Outdated
Show resolved
Hide resolved
doc/org.eclipse.cdt.doc.user/src/asciidoc/core_build_system.adoc
Outdated
Show resolved
Hide resolved
doc/org.eclipse.cdt.doc.user/src/asciidoc/core_build_system.adoc
Outdated
Show resolved
Hide resolved
doc/org.eclipse.cdt.doc.user/src/asciidoc/core_build_system.adoc
Outdated
Show resolved
Hide resolved
doc/org.eclipse.cdt.doc.user/src/asciidoc/core_build_system.adoc
Outdated
Show resolved
Hide resolved
doc/org.eclipse.cdt.doc.user/src/asciidoc/core_build_system.adoc
Outdated
Show resolved
Hide resolved
doc/org.eclipse.cdt.doc.user/src/asciidoc/core_build_system.adoc
Outdated
Show resolved
Hide resolved
de2e64e
to
52df7f8
Compare
I have included all John's suggestions. |
52df7f8
to
d7beb58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, @ewaterlander.
doc/org.eclipse.cdt.doc.user/src/asciidoc/core_build_system.adoc
Outdated
Show resolved
Hide resolved
d7beb58
to
21f46f7
Compare
I have rebased and will merge assuming acceptance by CI. @ewaterlander at the CDT call you mentioned that loading each page was very slow, when you get a chance can you test it again with my recent changes to see if I have resolved the issue. If you still have the problem, can you create a new issue please? |
A brief explanation of what the Core Build System is for end users.
21f46f7
to
ef50381
Compare
Thanks @ewaterlander for this valuable write-up. |
Hi @jonahgraham , Thanks for doing the rebase! I noticed today that Eclipse for committers requires the new glibc, as was announced. Unfortunately at the moment I'm working on machines that don't meet the requirement. Upgrade is in progress, but that may take some time. Perhaps I can get access to an upgraded machine sooner. I noticed the delay also on WSL, so I can test that right now. |
On WSL the pages now show without delay. It has improved a lot. Thanks! I did have a fight with proxy settings. For Eclipse Committers to do it's updates I need to have the proxies defined. But when I run CDT from Eclipse Committers I can't see any help page when proxies are defined. In the launch configuration I can set empty string values to http_proxy and https_proxy, but that doesn't work. They need to be undefined. It is not possible to undefine variables in the Environment tab. So to see the help I have to restart Eclipse Committers without proxies defined. |
Thanks for the feedback @ewaterlander Its been a while since I worked with proxy settings, but it sounds like the proxy is getting involved when destination is localhost (as it is when using help inside the IDE). I don't know how to resolve this, but just to confirm, does it look like:
You can stick with the older version of Eclipse for committers, it should be just fine. |
This is an initial description of the Core Build System for the user manual.
I think it should be placed just before the explanation of creating CMake and Makefile projects.