fix: podman login into external registries (#1120)

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
eclipse-che · May 31, 2024 · 0ab0c0c · 0ab0c0c
1 parent c89f94e
commit 0ab0c0c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/dashboard-backend/src/devworkspaceClient/services/__tests__/podmanApi.spec.ts b/packages/dashboard-backend/src/devworkspaceClient/services/__tests__/podmanApi.spec.ts
@@ -73,7 +73,7 @@ describe('podman Config API Service', () => {
         'sh',
         '-c',
         expect.stringContaining(
-          'podman login registry1 -u user1 -p password1 || true\npodman login registry2 -u user2 -p password2 || true',
+          "podman login registry1 -u 'user1' -p 'password1' || true\npodman login registry2 -u 'user2' -p 'password2' || true",
         ),
       ]),
       expect.anything(),

diff --git a/packages/dashboard-backend/src/devworkspaceClient/services/podmanApi.ts b/packages/dashboard-backend/src/devworkspaceClient/services/podmanApi.ts
@@ -176,7 +176,7 @@ export class PodmanApiService implements IPodmanApi {
 
         if (username && password) {
           // `|| true` ensures that `podman login` won't fail if credentials are invalid
-          externalDockerRegistriesPodmanLoginCommand += `podman login ${registry} -u ${username} -p ${password} || true\n`;
+          externalDockerRegistriesPodmanLoginCommand += `podman login ${registry} -u '${username}' -p '${password}' || true\n`;
         }
       }
     }