-
Notifications
You must be signed in to change notification settings - Fork 53
Implement editors/devfile route #1134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: David Kwon <dakwon@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1134 +/- ##
==========================================
- Coverage 89.61% 89.59% -0.03%
==========================================
Files 411 411
Lines 41920 41982 +62
Branches 2809 2824 +15
==========================================
+ Hits 37566 37613 +47
- Misses 4329 4343 +14
- Partials 25 26 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dkwon17 great job. Are the custom editors going to be exposed as well if configured ?
eclipse-che/che-docs#2738
@ibuziuk thank you, yes, custom editors are also exposed and are accessible from the new endpoint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but it seems there is a linting error that should be fixed via yarn lint:fix
packages/dashboard-frontend/src/contexts/WorkspaceActions/BulkDeleteButton/__mocks__/index.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: dkwon17 <dakwon@redhat.com>
Signed-off-by: dkwon17 <dakwon@redhat.com>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1134 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1134", name: che-dashboard}]}}]" |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1134 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1134", name: che-dashboard}]}}]" |
} as IShhKeysApi, | ||
} as DevWorkspaceClient; | ||
} | ||
export const getDevWorkspaceClient = jest.fn( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was done in order to provide certain mock implementations for certain tests:
che-dashboard/packages/dashboard-backend/src/routes/api/__tests__/editors.spec.ts
Line 67 in 64cb29d
(getDevWorkspaceClient as jest.Mock).mockImplementation(() => { |
@dkwon17 please, also contribute to the docs - https://eclipse.dev/che/docs/next/administration-guide/configuring-editors-definitions/ |
For eclipse-che/che-dashboard#1134 Signed-off-by: dkwon17 <dakwon@redhat.com>
For eclipse-che/che-dashboard#1134 Signed-off-by: dkwon17 <dakwon@redhat.com>
For eclipse-che/che-dashboard#1134 Signed-off-by: dkwon17 <dakwon@redhat.com>
For eclipse-che/che-dashboard#1134 Signed-off-by: dkwon17 <dakwon@redhat.com>
@ibuziuk here is the docs PR: eclipse-che/che-docs#2747 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dkwon17, ibuziuk, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dkwon17 I believe we are good to merge together withhttps://github.com/eclipse-che/che-docs/pull/2747 |
* feat: accessing editor devfile from dashboard url For eclipse-che/che-dashboard#1134 Signed-off-by: dkwon17 <dakwon@redhat.com> * Update editor links Signed-off-by: dkwon17 <dakwon@redhat.com> --------- Signed-off-by: dkwon17 <dakwon@redhat.com>
Build 3.15 :: dashboard_3.x/501: Console, Changes, Git Data |
Build 3.15 :: sync-to-downstream_3.x/6955: Console, Changes, Git Data |
What does this PR do?
This PR adds a new route exposed by the dashboard backend:

What issues does this PR fix or reference?
eclipse-che/che#22994
Is it tested? How?
When testing on Eclipse Che, access the following link and verify that the
che-code/latest
devfile is returned:If no
che-editor
query param is provided, then there is a 400 error:If there is not editor with id
che-editor
, there is a 404 error:Additionally, create this following devworkspace and verify that the workspace starts and verify that you can access the editor:
Release Notes
Docs PR