-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Dashboard should not allow to create a workspace if repo url is… #1192
Conversation
Skipping CI for Draft Pull Request. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1192 +/- ##
==========================================
+ Coverage 91.33% 91.35% +0.02%
==========================================
Files 439 440 +1
Lines 45404 45517 +113
Branches 3149 3158 +9
==========================================
+ Hits 41468 41582 +114
+ Misses 3936 3935 -1 ☔ View full report in Codecov by Sentry. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1192 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1192", name: che-dashboard}]}}]" |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1192 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1192", name: che-dashboard}]}}]" |
Co-authored-by: Oleksii Orel <oorel@redhat.com>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1192 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1192", name: che-dashboard}]}}]" |
packages/dashboard-frontend/src/store/ServerConfig/__tests__/selectors.spec.ts
Outdated
Show resolved
Hide resolved
packages/dashboard-frontend/src/components/WorkspaceProgress/CreatingSteps/Initialize/index.tsx
Outdated
Show resolved
Hide resolved
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1192 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1192", name: che-dashboard}]}}]" |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1192 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1192", name: che-dashboard}]}}]" |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, olexii4, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.17 :: dashboard_3.x/545: Console, Changes, Git Data |
Build 3.17 :: sync-to-downstream_3.x/7708: Console, Changes, Git Data |
… not in allowed list
What does this PR do?
Show an error when user try to start a workspace from disallowed source
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#23030
Is it tested? How?
kubectl patch checluster eclipse-che --patch '{"spec": {"devEnvironments": {"allowedSources": {"urls": ["https://gitlab.com/*"]}}}}' --type=merge -n eclipse-che
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1192", name: che-dashboard}]}}]"
Release Notes
Added support for specifying allowed sources from which Cloud Development Environments (CDEs) can be initiated.
URLs now support wildcard patterns (e.g., https://example.com/*), allowing flexible matching for CDE initiation.
Docs PR
eclipse-che/che-docs#2790