Skip to content

Added yarn v4 support #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Added yarn v4 support #1250

merged 1 commit into from
Mar 12, 2025

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Nov 6, 2024

What does this PR do?

Added yarn v4 support.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

It needs for https://issues.redhat.com/browse/CRW-7573

Is it tested? How?

Release Notes

Docs PR

@olexii4 olexii4 requested a review from SDawley November 6, 2024 15:16
@olexii4 olexii4 marked this pull request as ready for review November 6, 2024 15:18
@olexii4 olexii4 changed the title fix: babel plugins versions fix: upgrade yarn.lock Nov 7, 2024
@olexii4 olexii4 force-pushed the CRW-7573 branch 5 times, most recently from b8c2c2f to b461d98 Compare November 8, 2024 16:52
@eclipse-che eclipse-che deleted a comment from openshift-ci bot Nov 8, 2024
@eclipse-che eclipse-che deleted a comment from openshift-ci bot Nov 8, 2024
@eclipse-che eclipse-che deleted a comment from che-bot Nov 8, 2024
@eclipse-che eclipse-che deleted a comment from codecov bot Nov 8, 2024
@eclipse-che eclipse-che deleted a comment from github-actions bot Nov 8, 2024
@eclipse-che eclipse-che deleted a comment from github-actions bot Nov 8, 2024
@eclipse-che eclipse-che deleted a comment from github-actions bot Nov 8, 2024
@eclipse-che eclipse-che deleted a comment from github-actions bot Nov 8, 2024
@eclipse-che eclipse-che deleted a comment from github-actions bot Nov 8, 2024
@eclipse-che eclipse-che deleted a comment from github-actions bot Nov 8, 2024
@eclipse-che eclipse-che deleted a comment from github-actions bot Nov 8, 2024
@olexii4 olexii4 changed the title fix: upgrade yarn.lock [DO NOT MERGE] Added yarn v4 support Nov 8, 2024
@che-bot
Copy link
Contributor

che-bot commented Nov 8, 2024

Click here to review and test in web IDE: Contribute

Copy link

github-actions bot commented Nov 8, 2024

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1250

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1250", name: che-dashboard}]}}]"

1 similar comment
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1250

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1250", name: che-dashboard}]}}]"

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.74%. Comparing base (13063fb) to head (4c9e9b5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1250      +/-   ##
==========================================
- Coverage   91.91%   91.74%   -0.17%     
==========================================
  Files         501      501              
  Lines       45503    45502       -1     
  Branches     3194     3180      -14     
==========================================
- Hits        41825    41748      -77     
- Misses       3643     3720      +77     
+ Partials       35       34       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1250

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1250", name: che-dashboard}]}}]"

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1250

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1250", name: che-dashboard}]}}]"

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4 olexii4 changed the title [DO NOT MERGE] Added yarn v4 support Added yarn v4 support Mar 11, 2025
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1250

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1250", name: che-dashboard}]}}]"

Copy link
Contributor

@akurinnoy akurinnoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Mar 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olexii4 olexii4 merged commit 1725f13 into main Mar 12, 2025
21 of 22 checks passed
@olexii4 olexii4 deleted the CRW-7573 branch March 12, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants