Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: branding data merge #1298

Merged
merged 2 commits into from
Jan 22, 2025
Merged

fix: branding data merge #1298

merged 2 commits into from
Jan 22, 2025

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Jan 21, 2025

What does this PR do?

This PR fixes the branding data merge.

cherry-pick of #1297 to the 7.95.x branch

Screenshot/screencast of this PR

This PR was tested with branding from Dev Spaces 3.18.0 (file devspaces-dashboard/tree/packages/dashboard-frontend/assets/branding/product.json?h=devspaces-3.18-rhel-9)

See the test result on screenshot below
Знімок екрана 2025-01-21 о 19 32 34

What issues does this PR fix or reference?

fixes https://issues.redhat.com/browse/CRW-7935

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Jan 21, 2025

Click here to review and test in web IDE: Contribute

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1298

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1298", name: che-dashboard}]}}]"

@dmytro-ndp
Copy link
Contributor

@olexii4 : it looks like startWorkspaceFromGit property is not needed anymore in 7.95.x.
Could you please check and remove it?

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4
Copy link
Contributor Author

olexii4 commented Jan 21, 2025

@olexii4 : it looks like startWorkspaceFromGit property is not needed anymore in 7.95.x. Could you please check and remove it?

Thanks. I have removed it.

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1298

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1298", name: che-dashboard}]}}]"

Copy link

openshift-ci bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm label Jan 22, 2025
@olexii4 olexii4 merged commit 54ce4d1 into 7.95.x Jan 22, 2025
13 checks passed
@olexii4 olexii4 deleted the 7.95.x_CRW-7935 branch January 22, 2025 13:34
@devspacesbuild
Copy link

Build 3.18 :: dashboard_3.18/10: Console, Changes, Git Data

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.18 :: dashboard_3.18/10: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.18/353 triggered

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devstudio-release
Copy link

Build 3.18 :: copyIIBsToQuay/2900: Console, Changes, Git Data

@devspacesbuild
Copy link

Build 3.18 :: sync-to-downstream_3.18/354: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.18/362 triggered; /job/DS_CI/job/dsc_3.18 triggered;

@devspacesbuild
Copy link

Build 3.18 :: operator-bundle_3.18/299: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.18/354 triggered

@devspacesbuild
Copy link

Build 3.18 :: update-digests_3.18/360: SUCCESS

Detected new images: rebuild operator-bundle
* dashboard; /DS_CI/operator-bundle_3.18/299 triggered

@devspacesbuild
Copy link

Build 3.18 :: dsc_3.18/12: Console, Changes, Git Data

@devspacesbuild
Copy link

Build 3.18 :: dsc_3.18/12: SUCCESS

3.18.0-CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants