-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: branding data merge #1298
fix: branding data merge #1298
Conversation
Signed-off-by: Oleksii Orel <oorel@redhat.com>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1298 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1298", name: che-dashboard}]}}]" |
@olexii4 : it looks like |
Signed-off-by: Oleksii Orel <oorel@redhat.com>
Thanks. I have removed it. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1298 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1298", name: che-dashboard}]}}]" |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.18 :: dashboard_3.18/10: Console, Changes, Git Data |
Build 3.18 :: sync-to-downstream_3.18/353: Console, Changes, Git Data |
Build 3.18 :: push-latest-container-to-quay_3.18/41: Console, Changes, Git Data |
Build 3.18 :: get-sources-rhpkg-container-build_3.18/361: dashboard : 3.18 :: Build 66449170 : quay.io/devspaces/dashboard-rhel9:3.18-8 |
Build 3.18 :: update-digests_3.18/360: Console, Changes, Git Data |
Build 3.18 :: dashboard_3.18/10: Upstream sync done; /DS_CI/sync-to-downstream_3.18/353 triggered |
Build 3.18 :: operator-bundle_3.18/299: Console, Changes, Git Data |
Build 3.18 :: sync-to-downstream_3.18/354: Console, Changes, Git Data |
Build 3.18 :: push-latest-container-to-quay_3.18/42: Console, Changes, Git Data |
Build 3.18 :: copyIIBsToQuay/2900: Console, Changes, Git Data |
Build 3.18 :: sync-to-downstream_3.18/354: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.18/362 triggered; /job/DS_CI/job/dsc_3.18 triggered; |
Build 3.18 :: operator-bundle_3.18/299: Upstream sync done; /DS_CI/sync-to-downstream_3.18/354 triggered |
Build 3.18 :: update-digests_3.18/360: Detected new images: rebuild operator-bundle |
Build 3.18 :: dsc_3.18/12: Console, Changes, Git Data |
Build 3.18 :: dsc_3.18/12: 3.18.0-CI |
What does this PR do?
This PR fixes the branding data merge.
cherry-pick of #1297 to the 7.95.x branch
Screenshot/screencast of this PR
This PR was tested with branding from Dev Spaces 3.18.0 (file devspaces-dashboard/tree/packages/dashboard-frontend/assets/branding/product.json?h=devspaces-3.18-rhel-9)
See the test result on screenshot below
What issues does this PR fix or reference?
fixes https://issues.redhat.com/browse/CRW-7935