-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use git clone instead of curl to get airgap samples #1299
Conversation
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1299 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1299", name: che-dashboard}]}}]" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1299 +/- ##
==========================================
+ Coverage 91.54% 91.66% +0.12%
==========================================
Files 498 498
Lines 45449 45449
Branches 3157 3161 +4
==========================================
+ Hits 41605 41661 +56
+ Misses 3816 3756 -60
- Partials 28 32 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, olexii4, svor, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.19 :: dashboard_3.x/617: Console, Changes, Git Data |
Build 3.19 :: sync-to-downstream_3.x/8598: Console, Changes, Git Data |
Build 3.19 :: push-latest-container-to-quay_3.x/5060: Console, Changes, Git Data |
Build 3.19 :: get-sources-rhpkg-container-build_3.x/8704: dashboard : 3.x :: Build 66448836 : quay.io/devspaces/dashboard-rhel9:3.19-5 |
Build 3.19 :: update-digests_3.x/8430: Console, Changes, Git Data |
Build 3.19 :: dashboard_3.x/617: Upstream sync done; /DS_CI/sync-to-downstream_3.x/8598 triggered |
Build 3.19 :: operator-bundle_3.x/4310: Console, Changes, Git Data |
Build 3.19 :: sync-to-downstream_3.x/8600: Console, Changes, Git Data |
Build 3.19 :: get-sources-rhpkg-container-build_3.x/8706: devspaces-operator-bundle : 3.x :: Failed in 66449634 : BREW:BUILD/STATUS:UNKNOWN |
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
What does this PR do?
Uses
git clone
to get airgap samples instead ofcurl
with GH tokenWhat issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-7938
Is it tested? How?
index.json
Release Notes
N/A
Docs PR
N/A