Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use absolute path in local-run script to get air-gap samples #1301

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

svor
Copy link
Contributor

@svor svor commented Jan 22, 2025

What does this PR do?

Update the script to ensure it runs correctly in a local environment.

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-7938

Is it tested? How?

Try to execute local-run.sh script

Release Notes

N/A

Docs PR

N/A

Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
@svor svor self-assigned this Jan 22, 2025
@che-bot
Copy link
Contributor

che-bot commented Jan 22, 2025

Click here to review and test in web IDE: Contribute

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.57%. Comparing base (c8062f1) to head (40f8278).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1301      +/-   ##
==========================================
- Coverage   91.67%   91.57%   -0.11%     
==========================================
  Files         498      498              
  Lines       45447    45447              
  Branches     3167     3158       -9     
==========================================
- Hits        41663    41617      -46     
- Misses       3752     3798      +46     
  Partials       32       32              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@olexii4 olexii4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it with the dogfooding instance. All works as expected:

Знімок екрана 2025-01-23 о 04 54 25

Знімок екрана 2025-01-23 о 05 00 02

Great Job!

Copy link

openshift-ci bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: olexii4, svor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1301

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1301", name: che-dashboard}]}}]"

@svor svor merged commit 5af68a0 into main Jan 23, 2025
21 of 22 checks passed
@svor svor deleted the sv-fix-local-run branch January 23, 2025 08:42
@devspacesbuild
Copy link

Build 3.19 :: dashboard_3.x/619: Console, Changes, Git Data

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.19 :: dashboard_3.x/619: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/8607 triggered

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.19 :: get-sources-rhpkg-container-build_3.x/8714: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 66462286 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants