Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Change of verbiage to helper text under the 'Import from Git' text box. #1311

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix Change of verbiage to helper text under the 'Import from Git' text box. #1311

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f316fc0
Change of verbiage to helper text under the 'Import from Git' text box.
tyraziel Feb 4, 2025
2e0d8ea
Changed verbiage based on recommendations in PR.
tyraziel Feb 12, 2025
ca99793
Removed 'a devfile'
tyraziel Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...shboard-frontend/src/components/ImportFromGit/__tests__/__snapshots__/index.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ exports[`GitRepoLocationInput snapshot 1`] = `
className="pf-c-form__helper-text"
id="git-repo-url-helper"
>
Import from a Git repository to create your first workspace.
Import a devfile from a Git repository to create a new workspace or launch an existing one.
</div>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion packages/dashboard-frontend/src/components/ImportFromGit/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ class ImportFromGit extends React.PureComponent<Props, State> {
validated={validated}
helperTextInvalid={errorMessage}
helperTextInvalidIcon={<ExclamationCircleIcon />}
helperText="Import from a Git repository to create your first workspace."
helperText="Import a devfile from a Git repository to create a new workspace or launch an existing one."
tyraziel marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
helperText="Import a devfile from a Git repository to create a new workspace or launch an existing one."
helperText="Import from a Git repository to create a Cloud Development Environment"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tyraziel @olexii4 wdyt?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my main hangup is that if an environment of the same name already exists, it will ask if you want to open the existing one or create a new one. Trying to capture that concisely is the tricky part.

What if we changed it from "create" to "launch"? Does launch indicate create/open?

"Import from a Git repository to launch a Cloud Development Environment"

@ibuziuk @olexii4 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tyraziel "launch" sounds good 👍

Copy link
Author

@tyraziel tyraziel Feb 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Committed update @ibuziuk - ok to resolve conversation?

>
<Flex>
<FlexItem grow={{ default: 'grow' }} style={{ maxWidth: '500px', minWidth: '70%' }}>
Expand Down
Loading