Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the disable subdomain isolation property to false #2686

Closed
wants to merge 1 commit into from

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Feb 15, 2024

What does this pull request change?

  • Change the disable subdomain isolation property to false as most of GitHub server instances are running with enabled subdomain isolation property and it is recommended to enable the subdomain isolation in the GitHub setup page.
  • Wrap the false value in braces in order to meet the yaml format.

What issues does this pull request fix or reference?

fixes eclipse-che/che#22813

Specify the version of the product this pull request applies to

next

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@vinokurig vinokurig requested review from deerskindoll and a team as code owners February 15, 2024 11:52
@vinokurig vinokurig requested a review from nickboldt February 15, 2024 11:52
Copy link

github-actions bot commented Feb 15, 2024

🎊 Navigate the preview: https://65cf8a3a727fea08fd6de8a3--eclipse-che-docs-pr.netlify.app 🎊

Copy link

github-actions bot commented Feb 15, 2024

Click here to review and test in web IDE: Contribute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Subdomain isolation property mismatch with two GitHub oauth configurations
2 participants