Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trusted extensions #2717

Merged
merged 17 commits into from
Apr 10, 2024
Merged

Trusted extensions #2717

merged 17 commits into from
Apr 10, 2024

Conversation

vitaliy-guliy
Copy link
Contributor

@vitaliy-guliy vitaliy-guliy commented Apr 8, 2024

What does this pull request change?

Adds a page explaining how to specify trusted extensions for Microsoft VS Code editor.

Screenshot from 2024-04-09 21-38-12

What issues does this pull request fix or reference?

Part of eclipse-che/che#22781

Specify the version of the product this pull request applies to

che-code/7.84.0

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@vitaliy-guliy vitaliy-guliy requested review from deerskindoll and a team as code owners April 8, 2024 10:29
Copy link

github-actions bot commented Apr 8, 2024

🎊 Navigate the preview: https://6626795c49525f060e09028b--eclipse-che-docs-pr.netlify.app 🎊

Copy link

github-actions bot commented Apr 8, 2024

Click here to review and test in web IDE: Contribute

Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
devfile.yaml Show resolved Hide resolved
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of edits

vitaliy-guliy and others added 8 commits April 8, 2024 14:23
…osoft-visual-studio-code.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
…osoft-visual-studio-code.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
…osoft-visual-studio-code.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
…osoft-visual-studio-code.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
…osoft-visual-studio-code.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
…osoft-visual-studio-code.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of additional edits for added readability

vitaliy-guliy and others added 6 commits April 9, 2024 21:27
…osoft-visual-studio-code.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
…osoft-visual-studio-code.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
…osoft-visual-studio-code.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
…osoft-visual-studio-code.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
…osoft-visual-studio-code.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
…osoft-visual-studio-code.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
@vitaliy-guliy
Copy link
Contributor Author

vitaliy-guliy commented Apr 9, 2024

@deerskindoll Thanks for your help! I've updated the screenshot in the description to show what the current version looks like.
Is it ready to merge now?

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vitaliy-guliy
Copy link
Contributor Author

@deerskindoll one pull request check is failing. Could we merge the PR as it is or should we fix something?

@vitaliy-guliy
Copy link
Contributor Author

Merging this PR as the job is failing for other pull requests as well

@vitaliy-guliy vitaliy-guliy merged commit 81ad19d into main Apr 10, 2024
9 of 10 checks passed
@vitaliy-guliy vitaliy-guliy deleted the trusted-extensions branch April 10, 2024 07:44
@deerskindoll
Copy link
Contributor

Merging this PR as the job is failing for other pull requests as well

@vitaliy-guliy the check that's failing doesn't prevent merging because the other essential checks are fine

deerskindoll added a commit that referenced this pull request Apr 15, 2024
* docs: explain how to define VS Code trusted extensions

Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>

* docs: explain how to define VS Code trusted extensions

Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>

* Update modules/administration-guide/pages/trusted-extensions-for-microsoft-visual-studio-code.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>

* Update modules/administration-guide/pages/trusted-extensions-for-microsoft-visual-studio-code.adoc

---------

Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants