Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use vale COPR from Fedora 40 repo #2812

Merged
merged 1 commit into from
Nov 7, 2024
Merged

fix: use vale COPR from Fedora 40 repo #2812

merged 1 commit into from
Nov 7, 2024

Conversation

mkuznyetsov
Copy link
Contributor

What does this pull request change?

Container build is failing, because base image (podman/stable) is now based on Fedora 41
and so, the command to install Vale from COPR repo fails as it's not available for F41 , so this PR will make it installed from Fedora 40

Specify the version of the product this pull request applies to

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com>
@mkuznyetsov mkuznyetsov requested review from deerskindoll and a team as code owners November 7, 2024 08:08
@mkuznyetsov mkuznyetsov requested a review from tolusha November 7, 2024 08:08
Copy link

github-actions bot commented Nov 7, 2024

Click here to review and test in web IDE: Contribute

Copy link

github-actions bot commented Nov 7, 2024

🎊 Navigate the preview: 🎊

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mkuznyetsov mkuznyetsov merged commit e1a7fb8 into main Nov 7, 2024
10 of 12 checks passed
@mkuznyetsov mkuznyetsov deleted the release-hotfix branch November 7, 2024 11:03
mkuznyetsov added a commit that referenced this pull request Nov 7, 2024
Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants