update: Mark go as a required bin for otterdog #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok ty, that was missed as the gojsonnet wheel needs go to build. We will probably switch to https://pypi.org/project/rjsonnet/ that does not have this requirement and should be faster. |
Required by one of the dep packages in otterdog (gojsonnet).
netomi
force-pushed
the
malowe/main/go-req-doc
branch
from
153a8f4
to
7ca37b9
Compare
Signed-off-by: Thomas Neidhart <thomas.neidhart@eclipse-foundation.org>
Signed-off-by: Thomas Neidhart <thomas.neidhart@eclipse-foundation.org>
netomi
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required by one of the dep packages in otterdog (gojsonnet). W/o go installed the call to
make initwill fail due to an inability to build the wheel for gojsonnet, blocking the script.