remove the use of try for StsClient to avoid closing the client prema…

…turely
eclipse-ditto · Sep 18, 2024 · 5ab6b17 · 5ab6b17
1 parent 01fdc5a
commit 5ab6b17
Showing 1 changed file with 16 additions and 17 deletions.
diff --git a/...java/org/eclipse/ditto/internal/utils/persistence/mongo/auth/AwsAuthenticationHelper.java b/...java/org/eclipse/ditto/internal/utils/persistence/mongo/auth/AwsAuthenticationHelper.java
@@ -61,25 +61,24 @@ public static MongoCredential provideAwsIamBasedMongoCredential(
         }
 
         final Supplier<AwsCredential> awsFreshCredentialSupplier;
-        try (final StsClient stsClient = stsClientBuilder.build()) {
-            awsFreshCredentialSupplier = () -> {
-                LOGGER.info("Supplying AWS IAM credentials, assuming role <{}> in session name <{}>",
-                        awsRoleArn, awsSessionName);
+        final StsClient stsClient = stsClientBuilder.build();
+        awsFreshCredentialSupplier = () -> {
+            LOGGER.info("Supplying AWS IAM credentials, assuming role <{}> in session name <{}>",
+                    awsRoleArn, awsSessionName);
 
-                // assume role using the AWS SDK
-                final AssumeRoleRequest roleRequest = AssumeRoleRequest.builder()
-                        .roleArn(awsRoleArn)
-                        .roleSessionName(awsSessionName)
-                        .build();
-                final AssumeRoleResponse roleResponse = stsClient.assumeRole(roleRequest);
-                final Credentials awsCredentials = roleResponse.credentials();
+            // assume role using the AWS SDK
+            final AssumeRoleRequest roleRequest = AssumeRoleRequest.builder()
+                    .roleArn(awsRoleArn)
+                    .roleSessionName(awsSessionName)
+                    .build();
+            final AssumeRoleResponse roleResponse = stsClient.assumeRole(roleRequest);
+            final Credentials awsCredentials = roleResponse.credentials();
 
-                return new AwsCredential(awsCredentials.accessKeyId(), awsCredentials.secretAccessKey(),
-                        awsCredentials.sessionToken());
-            };
+            return new AwsCredential(awsCredentials.accessKeyId(), awsCredentials.secretAccessKey(),
+                    awsCredentials.sessionToken());
+        };
 
-            return MongoCredential.createAwsCredential(null, null)
-                    .withMechanismProperty(MongoCredential.AWS_CREDENTIAL_PROVIDER_KEY, awsFreshCredentialSupplier);
-        }
+        return MongoCredential.createAwsCredential(null, null)
+                .withMechanismProperty(MongoCredential.AWS_CREDENTIAL_PROVIDER_KEY, awsFreshCredentialSupplier);
     }
 }