Enhance Helm chart by startupProbe #2063
Merged
+275
−122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
thjaeckle
commented
Nov 15, 2024
thjaeckle
commented
- and more configuration options, e.g. several topologySpreadConstraints
- also configure "ephemeral-storage" requests and limits
thjaeckle
force-pushed
the
enhance-helm-chart-startup
branch
from
d2b8e31
to
16f8c06
Compare
* and more configuration options, e.g. several topologySpreadConstraints * also configure "ephemeral-storage" requests and limits
thjaeckle
force-pushed
the
enhance-helm-chart-startup
branch
from
16f8c06
to
2a87bd2
Compare
|
@kalinkostashki @alstanchev whoever wants to, a quick look at this would be nice. By using We also had the requirement to configure more than a single |
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.