[protobuf] Removed size check on cpp message types in protobuf reflec…

…tion. (#1730) Empty message fields are visible, e.g. in eCAL monitor protobuf reflection plugin
eclipse-ecal · Sep 9, 2024 · 3d67561 · 3d67561
1 parent 6f880f8
commit 3d67561
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 16 deletions.
diff --git a/contrib/ecalproto/src/ecal_proto_decoder.cpp b/contrib/ecalproto/src/ecal_proto_decoder.cpp
@@ -270,10 +270,8 @@ namespace protobuf
                 // do not process default messages to avoid infinite recursions.
                 std::vector<const google::protobuf::FieldDescriptor*> msg_fields;
                 msg.GetReflection()->ListFields(msg, &msg_fields);
-                if (msg_fields.size() > 0)
-                {
-                  ProcProtoMsg(msg, name.str(), complete_message_name, true, fnum);
-                }
+
+                ProcProtoMsg(msg, name.str(), complete_message_name, true, fnum);
               }
             }
           }
@@ -284,10 +282,8 @@ namespace protobuf
             // do not process default messages to avoid infinite recursions.
             std::vector<const google::protobuf::FieldDescriptor*> msg_fields;
             msg.GetReflection()->ListFields(msg, &msg_fields);
-            if (msg_fields.size() > 0)
-            {
-              ProcProtoMsg(msg, field->name(), complete_message_name, false, field->number());
-            }
+
+            ProcProtoMsg(msg, field->name(), complete_message_name, false, field->number());
           }
         }
         break;

diff --git a/samples/cpp/pubsub/protobuf/proto_dyn/src/proto_dyn.cpp b/samples/cpp/pubsub/protobuf/proto_dyn/src/proto_dyn.cpp
@@ -243,10 +243,8 @@ void ProcProtoMsg(const google::protobuf::Message& msg_, const std::string& pref
               // do not process default messages to avoid infinite recursions.
               std::vector<const google::protobuf::FieldDescriptor*> msg_fields;
               msg.GetReflection()->ListFields(msg, &msg_fields);
-              if (msg_fields.size() > 0)
-              {
-                ProcProtoMsg(msg, prefix);
-              }
+
+              ProcProtoMsg(msg, prefix);
             }
           }
           else
@@ -258,10 +256,8 @@ void ProcProtoMsg(const google::protobuf::Message& msg_, const std::string& pref
             // do not process default messages to avoid infinite recursions.
             std::vector<const google::protobuf::FieldDescriptor*> msg_fields;
             msg.GetReflection()->ListFields(msg, &msg_fields);
-            if (msg_fields.size() > 0)
-            {
-              ProcProtoMsg(msg, prefix);
-            }
+
+            ProcProtoMsg(msg, prefix);
           }
         }
         break;