Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Final API renaming for 5.12 #1153

Closed
wants to merge 2 commits into from
Closed

Core: Final API renaming for 5.12 #1153

wants to merge 2 commits into from

Conversation

KerstinKeller
Copy link
Contributor

GetTopicInformation -> GetDataTypeInformation
SetTopicInformation -> SetDataTypeInformation
SDataTypeInformation

Pull request type
API changes for 5.12 (only for types introduced since 5.11).

@KerstinKeller
Core: Final API renaming for 5.12
19b2b7f 
GetTopicInformation -> GetDataTypeInformation
SetTopicInformation -> SetDataTypeInformation
SDataTypeInformation
@KerstinKeller KerstinKeller requested review from rex-schilasky, hannemn and FlorianReimold and removed request for rex-schilasky and hannemn July 20, 2023 09:28
FlorianReimold
FlorianReimold requested changes Jul 21, 2023
View reviewed changes
Copy link
Member

@FlorianReimold FlorianReimold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very hard to review, but I did my best and marked every line that I think could be improved.

app/mon/mon_cli/src/ecal_mon_cli.cpp Show resolved Hide resolved
ecal/core_pb/src/ecal/core/pb/topic.proto Show resolved Hide resolved
ecal/core/src/service/ecal_service_server_impl.h Show resolved Hide resolved
ecal/core/src/service/ecal_service_server_impl.h Show resolved Hide resolved
ecal/core/src/service/ecal_service_server_impl.cpp Show resolved Hide resolved
ecal/core/src/ecal_registration_provider.h Show resolved Hide resolved
ecal/core/src/service/ecal_clientgate.cpp Show resolved Hide resolved
ecal/core/src/service/ecal_clientgate.cpp Show resolved Hide resolved
ecal/core/src/service/ecal_clientgate.cpp Show resolved Hide resolved
ecal/core/src/service/ecal_clientgate.cpp Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianReimold FlorianReimold FlorianReimold requested changes

@rex-schilasky rex-schilasky Awaiting requested review from rex-schilasky

@hannemn hannemn Awaiting requested review from hannemn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KerstinKeller @FlorianReimold