-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shorten default shm_monitoring_domain to avoid path length problems o… #1166
Conversation
Is that enough? If it is, then this will obviously get my approval |
Only as a remark: This option only influences the name prefix of the shared memory files that are used for shared memory monitoring and has no effect on the file names where the acutual payloads become tranfered. |
Yes, but as I understood, that also was the only issue, right? we already reduced the path length for the payload and event SHM files some time ago |
@hannemn are you sure? From the code it seems that every opened memory file for the monitoring will hold the prefix. |
Okay, I tought the shared memory file names of payload and event are even longer. But if this was fixed already some time ago, then your code adaptions should solve the name length issue good enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…n MacOS.
Please check the type of change your PR introduces:
Cherry-Pick to: