[core] description gate refactoring #1476

rex-schilasky · 2024-03-18T16:24:12Z

Description

DescGate logic refactored:

SHM and UDP registrations collected in common SampleList
ApplyDescription/Type whole quality logic moved to desc_gate.cpp unit
eCAL Initialize flag ProcessReg removed (should be set always)

Related issues

Needs to be written.

…r logic

… receiver to collect information descgate quality logic removed (will be obsolete with new id based descgate anyway)

github-actions

clang-tidy made some suggestions

github-actions · 2024-03-20T17:42:15Z

ecal/core/src/ecal_descgate.cpp

+      }
+    }
+      break;
+    case bct_unreg_service:


warning: switch has 3 consecutive identical branches [bugprone-branch-clone]

case bct_unreg_service: ^

Additional context

ecal/core/src/ecal_descgate.cpp:196: last of these clones ends here

break; ^

github-actions · 2024-03-20T17:42:15Z

ecal/core/src/ecal_descgate.cpp

+                                        , const SDataTypeInformation& request_type_information_
+                                        , const SDataTypeInformation& response_type_information_)
+  {
+    std::tuple<std::string, std::string> service_method_tuple = std::make_tuple(service_name_, method_name_);


warning: variable 'service_method_tuple' of type 'std::tuple<std::string, std::string>' (aka 'tuple<basic_string, basic_string>') can be declared 'const' [misc-const-correctness]

Suggested change

std::tuple<std::string, std::string> service_method_tuple = std::make_tuple(service_name_, method_name_);

std::tuple<std::string, std::string> const service_method_tuple = std::make_tuple(service_name_, method_name_);

github-actions · 2024-03-20T17:42:15Z

ecal/core/src/registration/ecal_registration_provider.cpp


+  Registration::Sample CRegistrationProvider::GetProcessRegisterSample()


warning: method 'GetProcessRegisterSample' can be made static [readability-convert-member-functions-to-static]

ecal/core/src/registration/ecal_registration_provider.h:74:

- Registration::Sample GetProcessRegisterSample(); + static Registration::Sample GetProcessRegisterSample();

github-actions · 2024-03-20T17:42:15Z

ecal/core/src/registration/ecal_registration_provider.cpp

  }

-  bool CRegistrationProvider::RegisterClient()
+  Registration::Sample CRegistrationProvider::GetProcessUnregisterSample()


warning: method 'GetProcessUnregisterSample' can be made static [readability-convert-member-functions-to-static]

ecal/core/src/registration/ecal_registration_provider.h:75:

- Registration::Sample GetProcessUnregisterSample(); + static Registration::Sample GetProcessUnregisterSample();

… process all remaining samples, like unregistrations)

…ce in case of finalizing nodes with a high number of pub/sub/client/server entities

github-actions

clang-tidy made some suggestions

github-actions · 2024-03-21T14:52:28Z

ecal/tests/cpp/util_test/src/util_test.cpp

 #include <ecal/ecal.h>
-#include <gtest/gtest.h>
 #include <util/frequency_calculator.h>


warning: 'util/frequency_calculator.h' file not found [clang-diagnostic-error]

#include <util/frequency_calculator.h> ^

github-actions · 2024-03-21T14:52:28Z

ecal/tests/cpp/util_test/src/util_test.cpp

@@ -193,3 +194,67 @@
    }
  }
 }
+
+TEST(core_cpp_util, ParallelGetTopics)


warning: all parameters should be named in a function [readability-named-parameter]

Suggested change

TEST(core_cpp_util, ParallelGetTopics)

TEST(core_cpp_util /*unused*/, ParallelGetTopics /*unused*/)

github-actions · 2024-03-21T14:52:28Z

ecal/tests/cpp/util_test/src/util_test.cpp

+    std::string topic_name = "Test.ParallelUtilFunctions";
+    std::atomic<int> call_back_count = 0;
+
+    std::vector<std::unique_ptr<eCAL::CPublisher>> publishers;


warning: variable 'publishers' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::vector<std::unique_ptr<eCAL::CPublisher>> publishers;

std::vector<std::unique_ptr<eCAL::CPublisher>> publishers = 0;

github-actions · 2024-03-21T14:52:29Z

ecal/tests/cpp/util_test/src/util_test.cpp

+
+    std::vector<std::unique_ptr<eCAL::CPublisher>> publishers;
+    for (int pub_count = 0; pub_count < max_publisher_count; pub_count++) {
+      std::unique_ptr<eCAL::CPublisher> publisher = std::make_unique<eCAL::CPublisher>(topic_name + std::to_string(pub_count));


warning: variable 'publisher' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::unique_ptr<eCAL::CPublisher> publisher = std::make_unique<eCAL::CPublisher>(topic_name + std::to_string(pub_count));

std::unique_ptr<eCAL::CPublisher> publisher = 0 = std::make_unique<eCAL::CPublisher>(topic_name + std::to_string(pub_count));

github-actions · 2024-03-21T14:52:29Z

ecal/tests/cpp/util_test/src/util_test.cpp

+
+  auto get_topics_from_ecal = [&]() {
+    size_t found_topics = 0;
+    std::vector<std::string> tmp_topic_names;


warning: variable 'tmp_topic_names' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::vector<std::string> tmp_topic_names;

std::vector<std::string> tmp_topic_names = 0;

github-actions · 2024-03-21T14:52:29Z

ecal/tests/cpp/util_test/src/util_test.cpp

+  auto get_topics_from_ecal = [&]() {
+    size_t found_topics = 0;
+    std::vector<std::string> tmp_topic_names;
+    std::unordered_map<std::string, eCAL::SDataTypeInformation> topics;


warning: variable 'topics' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::unordered_map<std::string, eCAL::SDataTypeInformation> topics;

std::unordered_map<std::string, eCAL::SDataTypeInformation> topics = 0;

github-actions · 2024-03-21T14:52:29Z

ecal/tests/cpp/util_test/src/util_test.cpp

+    } while (found_topics != 0);
+    };
+
+  std::vector<std::thread> threads_container;


warning: variable 'threads_container' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::vector<std::thread> threads_container;

std::vector<std::thread> threads_container = 0;

github-actions · 2024-03-21T14:52:29Z

ecal/tests/cpp/util_test/src/util_test.cpp

+    th.join();
+  }
+
+  std::vector<std::string> tmp_topic_names;


warning: variable 'tmp_topic_names' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::vector<std::string> tmp_topic_names;

std::vector<std::string> tmp_topic_names = 0;

github-actions · 2024-03-21T14:52:29Z

ecal/tests/cpp/util_test/src/util_test.cpp

+  }
+
+  std::vector<std::string> tmp_topic_names;
+  std::unordered_map<std::string, eCAL::SDataTypeInformation> topics;


warning: variable 'topics' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::unordered_map<std::string, eCAL::SDataTypeInformation> topics;

std::unordered_map<std::string, eCAL::SDataTypeInformation> topics = 0;

github-actions

clang-tidy made some suggestions

github-actions · 2024-03-21T17:33:04Z

ecal/core/src/ecal_descgate.cpp

+      }
+    }
+      break;
+    case bct_reg_client:


warning: switch has 2 consecutive identical branches [bugprone-branch-clone]

case bct_reg_client: ^

Additional context

ecal/core/src/ecal_descgate.cpp:206: last of these clones ends here

break; ^

github-actions · 2024-03-21T17:33:04Z

ecal/core/src/ecal_descgate.cpp

+
+  bool CDescGate::RemoveServiceDescription(const std::string& service_name_, const std::string& method_name_)
+  {
+    std::tuple<std::string, std::string> service_method_tuple = std::make_tuple(service_name_, method_name_);


warning: variable 'service_method_tuple' of type 'std::tuple<std::string, std::string>' (aka 'tuple<basic_string, basic_string>') can be declared 'const' [misc-const-correctness]

Suggested change

std::tuple<std::string, std::string> service_method_tuple = std::make_tuple(service_name_, method_name_);

std::tuple<std::string, std::string> const service_method_tuple = std::make_tuple(service_name_, method_name_);

github-actions · 2024-03-21T17:33:05Z

ecal/tests/cpp/util_test/src/util_test.cpp

+    th.join();
+  }
+
+  std::vector<std::string> final_topic_names;


warning: variable 'final_topic_names' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::vector<std::string> final_topic_names;

std::vector<std::string> final_topic_names = 0;

github-actions · 2024-03-21T17:33:05Z

ecal/tests/cpp/util_test/src/util_test.cpp

+  }
+
+  std::vector<std::string> final_topic_names;
+  std::unordered_map<std::string, eCAL::SDataTypeInformation> final_topics;


warning: variable 'final_topics' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::unordered_map<std::string, eCAL::SDataTypeInformation> final_topics;

std::unordered_map<std::string, eCAL::SDataTypeInformation> final_topics = 0;

github-actions

clang-tidy made some suggestions

github-actions · 2024-03-22T09:42:39Z

ecal/core/src/ecal_descgate.cpp

+namespace
+{
+  // TODO: remove me with new CDescGate
+  eCAL::CDescGate::QualityFlags GetServiceMethodQuality(const std::string& service_name_, const std::string& method_name_,


warning: parameter 'service_name_' is unused [misc-unused-parameters]

Suggested change

eCAL::CDescGate::QualityFlags GetServiceMethodQuality(const std::string& service_name_, const std::string& method_name_,

eCAL::CDescGate::QualityFlags GetServiceMethodQuality(const std::string& method_name_,

ecal/core/src/ecal_descgate.cpp:217:

- ApplyServiceDescription(sample_.service.sname, method.mname, request_type, response_type, GetServiceMethodQuality(sample_.service.sname, method.mname, request_type, response_type)); + ApplyServiceDescription(sample_.service.sname, method.mname, request_type, response_type, GetServiceMethodQuality(method.mname, request_type, response_type));

github-actions · 2024-03-22T09:42:40Z

ecal/core/src/ecal_descgate.cpp

+  eCAL::CDescGate::QualityFlags GetServiceMethodQuality(const std::string& service_name_, const std::string& method_name_,
+                                                        const eCAL::SDataTypeInformation& request_info_,


warning: parameter 'method_name_' is unused [misc-unused-parameters]

Suggested change

eCAL::CDescGate::QualityFlags GetServiceMethodQuality(const std::string& service_name_, const std::string& method_name_,

const eCAL::SDataTypeInformation& request_info_,

eCAL::CDescGate::QualityFlags GetServiceMethodQuality(const std::string& service_name_, const eCAL::SDataTypeInformation& request_info_,

ecal/core/src/ecal_descgate.cpp:217:

- ApplyServiceDescription(sample_.service.sname, method.mname, request_type, response_type, GetServiceMethodQuality(sample_.service.sname, method.mname, request_type, response_type)); + ApplyServiceDescription(sample_.service.sname, method.mname, request_type, response_type, GetServiceMethodQuality(sample_.service.sname, request_type, response_type));

github-actions · 2024-03-22T09:42:40Z

ecal/core/src/ecal_descgate.cpp

+    return quality;
+  }
+
+  eCAL::CDescGate::QualityFlags GetPublisherQuality(const std::string& topic_name_, const eCAL::SDataTypeInformation& topic_info_)


warning: parameter 'topic_name_' is unused [misc-unused-parameters]

Suggested change

eCAL::CDescGate::QualityFlags GetPublisherQuality(const std::string& topic_name_, const eCAL::SDataTypeInformation& topic_info_)

eCAL::CDescGate::QualityFlags GetPublisherQuality(const eCAL::SDataTypeInformation& topic_info_)

ecal/core/src/ecal_descgate.cpp:250:

- ApplyTopicDescription(sample_.topic.tname, sample_.topic.tdatatype, GetPublisherQuality(sample_.topic.tname, sample_.topic.tdatatype)); + ApplyTopicDescription(sample_.topic.tname, sample_.topic.tdatatype, GetPublisherQuality(sample_.topic.tdatatype));

github-actions · 2024-03-22T09:42:40Z

ecal/core/src/ecal_descgate.cpp

+    return quality;
+  }
+
+  eCAL::CDescGate::QualityFlags GetSubscriberQuality(const std::string& topic_name_, const eCAL::SDataTypeInformation& topic_info_)


warning: parameter 'topic_name_' is unused [misc-unused-parameters]

Suggested change

eCAL::CDescGate::QualityFlags GetSubscriberQuality(const std::string& topic_name_, const eCAL::SDataTypeInformation& topic_info_)

eCAL::CDescGate::QualityFlags GetSubscriberQuality(const eCAL::SDataTypeInformation& topic_info_)

ecal/core/src/ecal_descgate.cpp:256:

- ApplyTopicDescription(sample_.topic.tname, sample_.topic.tdatatype, GetSubscriberQuality(sample_.topic.tname, sample_.topic.tdatatype)); + ApplyTopicDescription(sample_.topic.tname, sample_.topic.tdatatype, GetSubscriberQuality(sample_.topic.tdatatype));

github-actions · 2024-03-22T09:42:40Z

ecal/core/src/ecal_descgate.cpp

+
+  bool CDescGate::GetServiceTypeNames(const std::string& service_name_, const std::string& method_name_, std::string& req_type_name_, std::string& resp_type_name_)
+  {
+    std::tuple<std::string, std::string> service_method_tuple = std::make_tuple(service_name_, method_name_);


warning: variable 'service_method_tuple' of type 'std::tuple<std::string, std::string>' (aka 'tuple<basic_string, basic_string>') can be declared 'const' [misc-const-correctness]

Suggested change

std::tuple<std::string, std::string> service_method_tuple = std::make_tuple(service_name_, method_name_);

std::tuple<std::string, std::string> const service_method_tuple = std::make_tuple(service_name_, method_name_);

github-actions · 2024-03-22T09:42:40Z

ecal/core/src/ecal_descgate.cpp

+
+  bool CDescGate::GetServiceDescription(const std::string& service_name_, const std::string& method_name_, std::string& req_type_desc_, std::string& resp_type_desc_)
+  {
+    std::tuple<std::string, std::string> service_method_tuple = std::make_tuple(service_name_, method_name_);


warning: variable 'service_method_tuple' of type 'std::tuple<std::string, std::string>' (aka 'tuple<basic_string, basic_string>') can be declared 'const' [misc-const-correctness]

Suggested change

std::tuple<std::string, std::string> service_method_tuple = std::make_tuple(service_name_, method_name_);

std::tuple<std::string, std::string> const service_method_tuple = std::make_tuple(service_name_, method_name_);

github-actions · 2024-03-22T09:42:40Z

ecal/core/src/ecal_descgate.cpp

+      }
+    }
+    break;
+    case bct_unreg_service:


warning: switch has 3 consecutive identical branches [bugprone-branch-clone]

case bct_unreg_service: ^

Additional context

ecal/core/src/ecal_descgate.cpp:248: last of these clones ends here

break; ^

github-actions

clang-tidy made some suggestions

github-actions · 2024-03-22T10:07:46Z

ecal/core/src/ecal_descgate.cpp

+      }
+    }
+    break;
+    case bct_unreg_service:


warning: switch has 3 consecutive identical branches [bugprone-branch-clone]

case bct_unreg_service: ^

Additional context

ecal/core/src/ecal_descgate.cpp:241: last of these clones ends here

break; ^

github-actions · 2024-03-22T10:07:46Z

ecal/tests/cpp/util_test/src/util_test.cpp

@@ -193,3 +194,72 @@ TEST(core_cpp_util, Freq_ResettableFrequencyCalculator)
    }
  }
 }
+
+


warning: all parameters should be named in a function [readability-named-parameter]

Suggested change

TEST(core_cpp_util /*unused*/, ParallelGetTopics /*unused*/)

github-actions · 2024-03-22T10:07:46Z

ecal/tests/cpp/util_test/src/util_test.cpp

+
+  auto create_publishers = [&]() {
+    std::string topic_name = "Test.ParallelUtilFunctions";
+    std::atomic<int> call_back_count{ 0 };


warning: variable 'publishers' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::atomic<int> call_back_count{ 0 };

std::vector<std::unique_ptr<eCAL::CPublisher>> publishers = 0;

github-actions · 2024-03-22T10:07:46Z

ecal/tests/cpp/util_test/src/util_test.cpp

+    std::string topic_name = "Test.ParallelUtilFunctions";
+    std::atomic<int> call_back_count{ 0 };
+
+    std::vector<std::unique_ptr<eCAL::CPublisher>> publishers;


warning: variable 'publisher' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::vector<std::unique_ptr<eCAL::CPublisher>> publishers;

std::unique_ptr<eCAL::CPublisher> publisher = 0 = std::make_unique<eCAL::CPublisher>(topic_name + std::to_string(pub_count));

github-actions · 2024-03-22T10:07:47Z

ecal/tests/cpp/util_test/src/util_test.cpp

+    std::this_thread::sleep_for(std::chrono::milliseconds(waiting_time_thread));
+    };
+
+  auto get_topics_from_ecal = [&]() {


warning: variable 'tmp_topic_names' is not initialized [cppcoreguidelines-init-variables]

Suggested change

auto get_topics_from_ecal = [&]() {

std::vector<std::string> tmp_topic_names = 0;

github-actions · 2024-03-22T10:07:47Z

ecal/tests/cpp/util_test/src/util_test.cpp

+    };
+
+  auto get_topics_from_ecal = [&]() {
+    size_t found_topics = 0;


warning: variable 'topics' is not initialized [cppcoreguidelines-init-variables]

Suggested change

size_t found_topics = 0;

std::unordered_map<std::string, eCAL::SDataTypeInformation> topics = 0;

github-actions · 2024-03-22T10:07:47Z

ecal/tests/cpp/util_test/src/util_test.cpp

+      std::cout << "Number of topics found by ecal: " << found_topics << "\n";
+      std::this_thread::sleep_for(std::chrono::milliseconds(500));
+    } while (found_topics != 0);
+    };


warning: variable 'threads_container' is not initialized [cppcoreguidelines-init-variables]

Suggested change

};

std::vector<std::thread> threads_container = 0;

github-actions · 2024-03-22T10:07:47Z

ecal/tests/cpp/util_test/src/util_test.cpp

+
+  for (auto& th : threads_container) {
+    th.join();
+  }


warning: variable 'final_topic_names' is not initialized [cppcoreguidelines-init-variables]

Suggested change

}

std::vector<std::string> final_topic_names = 0;

github-actions · 2024-03-22T10:07:47Z

ecal/tests/cpp/util_test/src/util_test.cpp

+  for (auto& th : threads_container) {
+    th.join();
+  }
+


warning: variable 'final_topics' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::unordered_map<std::string, eCAL::SDataTypeInformation> final_topics = 0;

KerstinKeller

Much cleaner 👍

KerstinKeller · 2024-03-22T09:51:37Z

ecal/tests/cpp/clientserver_test/src/clientserver_getservices.cpp

@@ -107,8 +106,7 @@ TEST(core_cpp_clientserver, GetServices)
    EXPECT_EQ(resp_desc, "foo::resp_desc1-1");

    // change attributes again (this will not overwrite the attributes anymore)
-    bool ret2 = server.AddDescription("foo::method1", "foo::req_type1-2", "foo::req_desc1-2", "foo::resp_type1-2", "foo::resp_desc1-2");
-    EXPECT_EQ(ret2, false);
+    server.AddDescription("foo::method1", "foo::req_type1-2", "foo::req_desc1-2", "foo::resp_type1-2", "foo::resp_desc1-2");



I like the new behavior better. Either you are allowed to set attributes, or you are not. Being allowed to set attributes once only is strange, but later we'll move it to constructor and have the behavior anyways...

KerstinKeller · 2024-03-22T09:53:46Z

ecal/core/src/service/ecal_service_server_impl.cpp

@@ -342,6 +317,7 @@ namespace eCAL

  void CServiceServerImpl::Register(const bool force_)
  {
+    if (!m_created)             return;


Can this lead to other unwanted side-effects?

KerstinKeller · 2024-03-22T10:07:26Z

ecal/core/src/registration/ecal_registration_provider.cpp

-      m_topics_map.erase(iter);
-      return(true);
+      // broadcast (updated) sample list over shm
+      SendSampleList2SHM();
    }


Don't you need #ifdef here like above? (#if ECAL_CORE_REGISTRATION_SHM,...)

KerstinKeller · 2024-03-22T10:08:26Z

ecal/core/src/registration/ecal_registration_provider.cpp

+#endif
+
+    // send out sample list over udp
+    SendSampleList2UDP();


again, here you need the #if ... ....

Btw, here would be a great point for a new refactoring (not in this PR!) - Have a list of Registration Layers, over which you iterate - this saves you the #if in many places.

KerstinKeller · 2024-03-22T10:20:18Z

ecal/core/src/registration/ecal_registration_provider.h

-    bool UnregisterClient(const std::string& client_name_, const std::string& client_id_, const Registration::Sample& ecal_sample_, bool force_);
+    using ApplySampleCallbackT = std::function<void(const Registration::Sample&)>;
+    void SetCustomApplySampleCallback(const std::string& customer_, const ApplySampleCallbackT& callback_);
+    void RemCustomApplySampleCallback(const std::string& customer_);


I think API-wise, something like this would be cleaner:

struct CallbackID { private: CallbackID(); int ID; } // You can now also omit the customer string, but if you potentially want to know, keep it CallbackID SetCustomApplySampleCallback(const std::string& customer_, const ApplySampleCallbackT& callback_); void RemCustomApplySampleCallback(const CallbackID & customer_);

Pros:

You don't need a map with a string (which are more expensive for lookup than ints).

Also you cannot try to remove something that you have never added - harder to missuse

-> No need for this PR but in general...

data race in reader, writer, client, server create/register/unregiste…

ab8fa6b

…r logic

rex-schilasky added cherry-pick-to-support/v5.12 Cherry pick these changes to support/v.5.12 cherry-pick-to-support/v5.13 Cherry pick these changes to support/v5.13 labels Mar 18, 2024

rex-schilasky added 2 commits March 18, 2024 17:48

atomic usage fixed

57bff30

descgate refactored, now using registration provider and registration…

5a6438f

… receiver to collect information descgate quality logic removed (will be obsolete with new id based descgate anyway)

rex-schilasky added cherry-pick-to-NONE Don't cherry-pick these changes and removed cherry-pick-to-support/v5.12 Cherry pick these changes to support/v.5.12 cherry-pick-to-support/v5.13 Cherry pick these changes to support/v5.13 labels Mar 20, 2024

rex-schilasky added 2 commits March 20, 2024 17:54

pubsub_test adapted to new, simple descgate logic

7123bf4

init flag ProcessReg removed

3cc7168

github-actions bot reviewed Mar 20, 2024

View reviewed changes

rex-schilasky changed the title ~~[core] possible data race in create/register/unregister logic~~ [core] description gate refactoring Mar 21, 2024

do not clear the sample list on registration provider destruction (to…

10c6fbd

… process all remaining samples, like unregistrations)

rex-schilasky marked this pull request as ready for review March 21, 2024 12:18

rex-schilasky added 2 commits March 21, 2024 13:27

do unregistration "unforced", this will lead to much higher performan…

f44181f

…ce in case of finalizing nodes with a high number of pub/sub/client/server entities

util test ParallelGetTopics added

85e6564

github-actions bot reviewed Mar 21, 2024

View reviewed changes

std::atomic<int> initialization fixed

a72a59d

rex-schilasky marked this pull request as draft March 21, 2024 16:52

unregistration utilized in CDescGate

8c54eae

github-actions bot reviewed Mar 21, 2024

View reviewed changes

quality logic reintroduced in description gate to get this PR done

55aff9d

rex-schilasky marked this pull request as ready for review March 22, 2024 09:40

rex-schilasky requested a review from KerstinKeller March 22, 2024 09:40

github-actions bot reviewed Mar 22, 2024

View reviewed changes

rex-schilasky added 3 commits March 22, 2024 10:43

missing include fixed

cd39afa

removed unused parameter and functions

0665134

util test corrected (dependency from ECAL_CORE_PUBLISHER option)

dcf1844

github-actions bot reviewed Mar 22, 2024

View reviewed changes

KerstinKeller approved these changes Mar 22, 2024

View reviewed changes

rex-schilasky merged commit f1d8efe into master Mar 22, 2024
15 checks passed

rex-schilasky deleted the hotfix/register-unregister-data-race branch March 22, 2024 11:21

	std::tuple<std::string, std::string> service_method_tuple = std::make_tuple(service_name_, method_name_);
	std::tuple<std::string, std::string> const service_method_tuple = std::make_tuple(service_name_, method_name_);


		Registration::Sample CRegistrationProvider::GetProcessRegisterSample()

	TEST(core_cpp_util, ParallelGetTopics)
	TEST(core_cpp_util /unused/, ParallelGetTopics /unused/)

	std::vector<std::unique_ptr<eCAL::CPublisher>> publishers;
	std::vector<std::unique_ptr<eCAL::CPublisher>> publishers = 0;

	std::unique_ptr<eCAL::CPublisher> publisher = std::make_unique<eCAL::CPublisher>(topic_name + std::to_string(pub_count));
	std::unique_ptr<eCAL::CPublisher> publisher = 0 = std::make_unique<eCAL::CPublisher>(topic_name + std::to_string(pub_count));

	std::vector<std::string> tmp_topic_names;
	std::vector<std::string> tmp_topic_names = 0;

	std::unordered_map<std::string, eCAL::SDataTypeInformation> topics;
	std::unordered_map<std::string, eCAL::SDataTypeInformation> topics = 0;

	std::vector<std::thread> threads_container;
	std::vector<std::thread> threads_container = 0;

	std::vector<std::string> final_topic_names;
	std::vector<std::string> final_topic_names = 0;

	eCAL::CDescGate::QualityFlags GetServiceMethodQuality(const std::string& service_name_, const std::string& method_name_,
	eCAL::CDescGate::QualityFlags GetServiceMethodQuality(const std::string& method_name_,

		eCAL::CDescGate::QualityFlags GetServiceMethodQuality(const std::string& service_name_, const std::string& method_name_,
		const eCAL::SDataTypeInformation& request_info_,

	eCAL::CDescGate::QualityFlags GetPublisherQuality(const std::string& topic_name_, const eCAL::SDataTypeInformation& topic_info_)
	eCAL::CDescGate::QualityFlags GetPublisherQuality(const eCAL::SDataTypeInformation& topic_info_)

	eCAL::CDescGate::QualityFlags GetSubscriberQuality(const std::string& topic_name_, const eCAL::SDataTypeInformation& topic_info_)
	eCAL::CDescGate::QualityFlags GetSubscriberQuality(const eCAL::SDataTypeInformation& topic_info_)

@@ @@ -193,3 +194,72 @@ TEST(core_cpp_util, Freq_ResettableFrequencyCalculator) @@
                   }
                 }
               }

	std::atomic<int> call_back_count{ 0 };
	std::vector<std::unique_ptr<eCAL::CPublisher>> publishers = 0;

	auto get_topics_from_ecal = [&]() {
	std::vector<std::string> tmp_topic_names = 0;

	size_t found_topics = 0;
	std::unordered_map<std::string, eCAL::SDataTypeInformation> topics = 0;

[core] description gate refactoring #1476

[core] description gate refactoring #1476

Conversation

rex-schilasky commented Mar 18, 2024 • edited Loading

Description

Related issues

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Mar 20, 2024

Choose a reason for hiding this comment

github-actions bot Mar 20, 2024

Choose a reason for hiding this comment

github-actions bot Mar 20, 2024

Choose a reason for hiding this comment

github-actions bot Mar 20, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Mar 21, 2024

Choose a reason for hiding this comment

github-actions bot Mar 21, 2024

Choose a reason for hiding this comment

github-actions bot Mar 21, 2024

Choose a reason for hiding this comment

github-actions bot Mar 21, 2024

Choose a reason for hiding this comment

github-actions bot Mar 21, 2024

Choose a reason for hiding this comment

github-actions bot Mar 21, 2024

Choose a reason for hiding this comment

github-actions bot Mar 21, 2024

Choose a reason for hiding this comment

github-actions bot Mar 21, 2024

Choose a reason for hiding this comment

github-actions bot Mar 21, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Mar 21, 2024

Choose a reason for hiding this comment

github-actions bot Mar 21, 2024

Choose a reason for hiding this comment

github-actions bot Mar 21, 2024

Choose a reason for hiding this comment

github-actions bot Mar 21, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Mar 22, 2024

Choose a reason for hiding this comment

github-actions bot Mar 22, 2024

Choose a reason for hiding this comment

github-actions bot Mar 22, 2024

Choose a reason for hiding this comment

github-actions bot Mar 22, 2024

Choose a reason for hiding this comment

github-actions bot Mar 22, 2024

Choose a reason for hiding this comment

github-actions bot Mar 22, 2024

Choose a reason for hiding this comment

github-actions bot Mar 22, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Mar 22, 2024

Choose a reason for hiding this comment

github-actions bot Mar 22, 2024

Choose a reason for hiding this comment

github-actions bot Mar 22, 2024

Choose a reason for hiding this comment

github-actions bot Mar 22, 2024

Choose a reason for hiding this comment

github-actions bot Mar 22, 2024

Choose a reason for hiding this comment

github-actions bot Mar 22, 2024

Choose a reason for hiding this comment

github-actions bot Mar 22, 2024

Choose a reason for hiding this comment

github-actions bot Mar 22, 2024

Choose a reason for hiding this comment

rex-schilasky commented Mar 18, 2024 •

edited

Loading