Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] move find_package(Protobuf) to bottom #1581

Closed
wants to merge 1 commit into from

Conversation

KerstinKeller
Copy link
Contributor

... as abseil (required in newer protobuf versions) somehow messes with paths, and then the following includes fail.

... as abseil (required in newer protobuf versions) somehow messes with paths, and then the following includes fail.
@KerstinKeller KerstinKeller added cherry-pick-to-support/v5.12 Cherry pick these changes to support/v.5.12 cherry-pick-to-support/v5.13 Cherry pick these changes to support/v5.13 labels May 3, 2024
@FlorianReimold
Copy link
Member

Warning: This PR goes to 5.13. the 5.13 branch doesn't have a cherry-pick action at the moment. The PR is labled as cherry-pick to 5.13 though, which makes me assume that the base branch is wrong.

@KerstinKeller
Copy link
Contributor Author

you are right. das nervt ein bisschen, wenn man seine änderungen direkt aus der weboberfläche macht.
I will make another PR based on master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-to-support/v5.12 Cherry pick these changes to support/v.5.12 cherry-pick-to-support/v5.13 Cherry pick these changes to support/v5.13
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants