-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] expmap performance improvement #1626
Conversation
…th > 25 k entries)
monitoring_get_topics sample slightly improved to allow time updates of internal (large) expmaps in case of subsequent readings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm as discussed
* performance improvement of update_timestamp for large maps (tested with > 25 k entries) * monitoring_get_topics sample slightly improved to allow time updates of internal (large) expmaps in case of subsequent readings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
|
||
int main(int argc, char **argv) | ||
{ | ||
int run(0), runs(1000); | ||
int run(0), runs(10); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: multiple declarations in a single statement reduces readability [readability-isolate-declaration]
int run(0), runs(10); | |
int run(0); | |
int runs(10); |
* performance improvement of update_timestamp for large maps (tested with > 25 k entries) * monitoring_get_topics sample slightly improved to allow time updates of internal (large) expmaps in case of subsequent readings
* performance improvement of update_timestamp for large maps (tested with > 25 k entries) * monitoring_get_topics sample slightly improved to allow time updates of internal (large) expmaps in case of subsequent readings Co-authored-by: Rex Schilasky <49162693+rex-schilasky@users.noreply.github.com>
Description
For large maps the
update_timestamps
function is not performing well.Changes:
_key_to_value
map, rather than using at, which would throw an exception if the key is not found._key_tracker
list, the new version uses the splice function to move the element to the end of the list, improving efficiency.