[protobuf] Readded msg_size and field name check to ProcProtoMsg recursion #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peguen
added
the
cherry-pick-to-support/v5.13
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ecal/samples/cpp/pubsub/protobuf/proto_dyn_rec/src/proto_dyn_rec.cpp
Outdated
Show resolved
Hide resolved
ecal/samples/cpp/pubsub/protobuf/proto_dyn_rec/src/proto_dyn_rec.cpp
Outdated
Show resolved
Hide resolved
KerstinKeller
approved these changes
Sep 12, 2024
Peguen
added a commit
that referenced
this pull request
Sep 13, 2024
…rsion (#1734) * Added msg_size and string find check to ProcProtoMsg recursion. * Added same logic to dyn_proto sample
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To avoid infinite recursive for recursive proto definitions readded the msg_size check and additionally a field name find check. The later enables the msg to show at least one default submsg, even if every field is just a default value.