Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Parallel serialization test. #1778

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[core] Parallel serialization test. #1778

wants to merge 2 commits into from

Conversation

KerstinKeller
Copy link
Contributor

Header files for serialization_test.

@KerstinKeller
[core] Parallel serialization test.
7b7a024 
Header files for serialization_test.
@KerstinKeller KerstinKeller added the cherry-pick-to-NONE Don't cherry-pick these changes label Nov 4, 2024
github-actions[bot]
github-actions bot reviewed Nov 4, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

ecal/tests/cpp/serialization_test/src/logging_serialization_test.cpp
@@ -17,17 +17,17 @@
* ========================= eCAL LICENSE =================================
*/

#include "../../serialization/ecal_serialize_logging.h"
#include <serialization/ecal_serialize_logging.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'serialization/ecal_serialize_logging.h' file not found [clang-diagnostic-error]

#include <serialization/ecal_serialize_logging.h>
         ^

ecal/tests/cpp/serialization_test/src/monitoring_serialization_test.cpp
@@ -17,17 +17,16 @@
* ========================= eCAL LICENSE =================================
*/

#include "../../serialization/ecal_serialize_monitoring.h"
#include <serialization/ecal_serialize_monitoring.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'serialization/ecal_serialize_monitoring.h' file not found [clang-diagnostic-error]

#include <serialization/ecal_serialize_monitoring.h>
         ^

ecal/tests/cpp/serialization_test/src/parallel_serialization_test.cpp
* ========================= eCAL LICENSE =================================
*/

#include "serialization/ecal_serialize_logging.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'serialization/ecal_serialize_logging.h' file not found [clang-diagnostic-error]

#include "serialization/ecal_serialize_logging.h"
         ^

ecal/tests/cpp/serialization_test/src/parallel_serialization_test.cpp
{
void SerializeLogMessage()
{
Logging::SLogMessage message_in = Logging::GenerateLogMessage();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: variable 'message_in' of type 'Logging::SLogMessage' can be declared 'const' [misc-const-correctness]

Suggested change
Logging::SLogMessage message_in = Logging::GenerateLogMessage();
Logging::SLogMessage const message_in = Logging::GenerateLogMessage();

ecal/tests/cpp/serialization_test/src/parallel_serialization_test.cpp

for (int i = 0; i < 10000; ++i)
{
std::string message_buffer;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: variable 'message_buffer' is not initialized [cppcoreguidelines-init-variables]

Suggested change
std::string message_buffer;
std::string message_buffer = 0;

ecal/tests/cpp/serialization_test/src/payload_serialization_test.cpp
@@ -17,7 +17,10 @@
* ========================= eCAL LICENSE =================================
*/

#include "../../serialization/ecal_serialize_sample_payload.h"
#include <serialization/ecal_serialize_sample_payload.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'serialization/ecal_serialize_sample_payload.h' file not found [clang-diagnostic-error]

#include <serialization/ecal_serialize_sample_payload.h>
         ^

ecal/tests/cpp/serialization_test/src/registration_serialization_test.cpp
@@ -17,7 +17,7 @@
* ========================= eCAL LICENSE =================================
*/

#include "../../serialization/ecal_serialize_sample_registration.h"
#include <serialization/ecal_serialize_sample_registration.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'serialization/ecal_serialize_sample_registration.h' file not found [clang-diagnostic-error]

#include <serialization/ecal_serialize_sample_registration.h>
         ^

ecal/tests/cpp/serialization_test/src/service_compare.h
*/
#pragma once

#include <serialization/ecal_struct_service.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'serialization/ecal_struct_service.h' file not found [clang-diagnostic-error]

#include <serialization/ecal_struct_service.h>
         ^

ecal/tests/cpp/serialization_test/src/service_generate.h

#pragma once

#include <serialization/ecal_struct_service.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'serialization/ecal_struct_service.h' file not found [clang-diagnostic-error]

#include <serialization/ecal_struct_service.h>
         ^

ecal/tests/cpp/serialization_test/src/service_serialization_test.cpp
@@ -17,20 +17,16 @@
* ========================= eCAL LICENSE =================================
*/

#include "../../serialization/ecal_serialize_service.h"
#include <serialization/ecal_serialize_service.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'serialization/ecal_serialize_service.h' file not found [clang-diagnostic-error]

#include <serialization/ecal_serialize_service.h>
         ^

rex-schilasky
rex-schilasky approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@rex-schilasky rex-schilasky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@rex-schilasky rex-schilasky rex-schilasky approved these changes

Assignees
No one assigned
Labels
cherry-pick-to-NONE Don't cherry-pick these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KerstinKeller @rex-schilasky