Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Parallel serialization test. #1778

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

KerstinKeller
Copy link
Contributor

Header files for serialization_test.

Header files for serialization_test.
@KerstinKeller KerstinKeller added the cherry-pick-to-NONE Don't cherry-pick these changes label Nov 4, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@@ -17,17 +17,17 @@
* ========================= eCAL LICENSE =================================
*/

#include "../../serialization/ecal_serialize_logging.h"
#include <serialization/ecal_serialize_logging.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'serialization/ecal_serialize_logging.h' file not found [clang-diagnostic-error]

#include <serialization/ecal_serialize_logging.h>
         ^

@@ -17,17 +17,16 @@
* ========================= eCAL LICENSE =================================
*/

#include "../../serialization/ecal_serialize_monitoring.h"
#include <serialization/ecal_serialize_monitoring.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'serialization/ecal_serialize_monitoring.h' file not found [clang-diagnostic-error]

#include <serialization/ecal_serialize_monitoring.h>
         ^

* ========================= eCAL LICENSE =================================
*/

#include "serialization/ecal_serialize_logging.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'serialization/ecal_serialize_logging.h' file not found [clang-diagnostic-error]

#include "serialization/ecal_serialize_logging.h"
         ^

{
void SerializeLogMessage()
{
Logging::SLogMessage message_in = Logging::GenerateLogMessage();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: variable 'message_in' of type 'Logging::SLogMessage' can be declared 'const' [misc-const-correctness]

Suggested change
Logging::SLogMessage message_in = Logging::GenerateLogMessage();
Logging::SLogMessage const message_in = Logging::GenerateLogMessage();


for (int i = 0; i < 10000; ++i)
{
std::string message_buffer;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: variable 'message_buffer' is not initialized [cppcoreguidelines-init-variables]

Suggested change
std::string message_buffer;
std::string message_buffer = 0;

@@ -17,7 +17,10 @@
* ========================= eCAL LICENSE =================================
*/

#include "../../serialization/ecal_serialize_sample_payload.h"
#include <serialization/ecal_serialize_sample_payload.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'serialization/ecal_serialize_sample_payload.h' file not found [clang-diagnostic-error]

#include <serialization/ecal_serialize_sample_payload.h>
         ^

@@ -17,7 +17,7 @@
* ========================= eCAL LICENSE =================================
*/

#include "../../serialization/ecal_serialize_sample_registration.h"
#include <serialization/ecal_serialize_sample_registration.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'serialization/ecal_serialize_sample_registration.h' file not found [clang-diagnostic-error]

#include <serialization/ecal_serialize_sample_registration.h>
         ^

*/
#pragma once

#include <serialization/ecal_struct_service.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'serialization/ecal_struct_service.h' file not found [clang-diagnostic-error]

#include <serialization/ecal_struct_service.h>
         ^


#pragma once

#include <serialization/ecal_struct_service.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'serialization/ecal_struct_service.h' file not found [clang-diagnostic-error]

#include <serialization/ecal_struct_service.h>
         ^

@@ -17,20 +17,16 @@
* ========================= eCAL LICENSE =================================
*/

#include "../../serialization/ecal_serialize_service.h"
#include <serialization/ecal_serialize_service.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'serialization/ecal_serialize_service.h' file not found [clang-diagnostic-error]

#include <serialization/ecal_serialize_service.h>
         ^

Copy link
Contributor

@rex-schilasky rex-schilasky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done.

@KerstinKeller KerstinKeller merged commit 066471a into master Nov 8, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-to-NONE Don't cherry-pick these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants