Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo #119

Closed
wants to merge 1 commit into from
Closed

docs: fix typo #119

wants to merge 1 commit into from

Conversation

mbkma
Copy link

@mbkma mbkma commented Sep 15, 2023

What this PR changes/adds

It fixes the typo such that the curl command works again.

Why it does that

The -s should be the silent option of the curl command and not piped.

Further notes

btw this link in the Contributing.md is broken: https://github.com/eclipse-edc/docs/blob/e7730f432305775542503e4ecb61aa7e829bea30/CONTRIBUTING.md?plain=1#L132

Linked Issue(s)

None

@mbkma mbkma requested a review from ronjaquensel as a code owner September 15, 2023 09:35
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'We are always happy to welcome new contributors ❤️ To make things easier for everyone, please - make sure to follow our contribution guidelines, - check if you have already signed the ECA, and - relate this pull request to an existing issue or discussion.'

@ndr-brt ndr-brt added the bug Something isn't working label Sep 15, 2023
@ndr-brt
Copy link
Member

ndr-brt commented Sep 15, 2023

Generally, you should have an open issue before opening a PR, this is a short fix so we can overlook that, but please read our contributing guide carefully.
One thing that we cannot ignore is the ECA, it must be signed, otherwise the PR cannot be merged

@github-actions
Copy link

This pull request is stale because it has been open for 7 days with no activity.

@github-actions github-actions bot added the stale Open for x days with no activity label Sep 23, 2023
@mbkma
Copy link
Author

mbkma commented Sep 26, 2023

Hi, sorry for my late response. I am currently in the process of clarifying whether or not I can sign the ECA. I will come back once things got clarified.

@github-actions github-actions bot removed the stale Open for x days with no activity label Sep 27, 2023
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

This pull request is stale because it has been open for 7 days with no activity.

@github-actions github-actions bot added the stale Open for x days with no activity label Oct 4, 2023
@github-actions
Copy link

This pull request was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this Oct 12, 2023
@mbkma mbkma deleted the fix/fix-typo branch December 27, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale Open for x days with no activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants