Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide kafka-broker transfer streaming sample #151

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Nov 15, 2023

What this PR changes/adds

Adds a streaming kafka-broker sample, that shows how to stream data through EDC with a custom DataFlowController without using the data-plane.

Why it does that

streaming

Further notes

  • removed the Checkstyle job in the ci as Build already runs checkstyle
  • cleanup FileTransferCommon, that contained a lot of unused methods

Linked Issue(s)

Closes #150

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the enhancement New feature or request label Nov 15, 2023
@bscholtes1A
Copy link

This is awesome!
Small question though, could the set of .json files be replaced by a Postman collection?
The advantage is that the placeholder values can be set as collection variables.

Also doing so it is possible to automate the process of extracting the value from a response to set a variable for the next request .

@ndr-brt
Copy link
Member Author

ndr-brt commented Nov 17, 2023

This is awesome! Small question though, could the set of .json files be replaced by a Postman collection? The advantage is that the placeholder values can be set as collection variables.

Also doing so it is possible to automate the process of extracting the value from a response to set a variable for the next request .

currently all the samples work with json files, because they can be used both in the sample manual process and in the automated tests. The postman thing could be proposed in a new issue eventually

@ndr-brt ndr-brt merged commit ec0a302 into eclipse-edc:main Nov 20, 2023
7 of 9 checks passed
@ndr-brt ndr-brt deleted the 150-kafka-to-kafka branch November 20, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create kafka-broker sample
2 participants