fix: update transfer-05-file-transfer-cloud sample #247
Conversation
bpetrovbg
requested review from
paullatzelsperger and
ronjaquensel
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
'We are always happy to welcome new contributors ❤️ To make things easier for everyone, please - make sure to follow our contribution guidelines, - check if you have already signed the ECA, and - relate this pull request to an existing issue or discussion.'
| @@ -36,6 +36,20 @@ dependencies { | |||
| implementation(libs.edc.dsp) | |||
|
|
|||
| implementation(libs.edc.data.plane.selector.core) | |||
|
|
|||
| //configuration from earlier examples | |||
There was a problem hiding this comment.
this is not "configuration" but these are dependencies, please update the comment accordingly (or removing it altogether, as it is not really necessary). same for the other build file
There was a problem hiding this comment.
you are right, I just did a minor cleanup 😉
|
@bpetrovbg please fix the PR name according to the convention https://eclipse-edc.github.io/docs/#/documentation/CONTRIBUTING |
bpetrovbg
changed the title
bpetrovbg
changed the title
There was a problem hiding this comment.
@bpetrovbg the PR name is still not valid: https://github.com/eclipse-edc/Samples/actions/runs/8875401453/job/24366181117?pr=247
bpetrovbg
changed the title
bpetrovbg
changed the title
yes, the name was probably too long... 😀 |
What this PR changes/adds
updates the provider/consumer configurations, builds and README for transfer-05-file-transfer-cloud
Why it does that
Sample is out of date.
Linked Issue(s)
Closes Issue fetching Retrieve provider Contract Offers