build: bump EDC to 0.6.4 #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
force-pushed
the
bump-edc
branch
3 times, most recently
from
ccd45fb to
3c1d21c
Compare
ndr-brt
force-pushed
the
bump-edc
branch
3 times, most recently
from
e72d4a1 to
209ac58
Compare
paullatzelsperger
approved these changes
May 14, 2024
| @@ -90,7 +90,7 @@ void setUp() throws IOException { | |||
| @Test | |||
| void streamData() throws IOException { | |||
| var source = Files.createTempDirectory("source"); | |||
| PROVIDER.registerDataPlane(List.of("HttpStreaming"), List.of("HttpData")); | |||
| PROVIDER.registerDataPlane(List.of("HttpStreaming"), List.of("HttpData"), List.of("HttpData-PUSH")); | |||
There was a problem hiding this comment.
should that not be
Suggested change
| PROVIDER.registerDataPlane(List.of("HttpStreaming"), List.of("HttpData"), List.of("HttpData-PUSH")); | |
| PROVIDER.registerDataPlane(List.of("HttpStreaming"), List.of("HttpData-PULL"), List.of("HttpData-PUSH")); |
There was a problem hiding this comment.
no, because in this method the second parameter is about "destination types", that don't contain the flow type. Anyway this registration will go away soon :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Bump EDC to 0.6.4
Why it does that
Briefly state why the change was necessary.
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes # <-- insert Issue number if one exists
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.