-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for minio and azurite for cloud sample #297
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'We are always happy to welcome new contributors ❤️ To make things easier for everyone, please - make sure to follow our contribution guidelines, - check if you have already signed the ECA, and - relate this pull request to an existing issue or discussion.'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please substitute this to the transfer-05
, because at this point it become pointless.
An automated test in system-tests
is mandatory to protect sample functionality against regressions
This pull request is stale because it has been open for 7 days with no activity. |
I am currently working on the test, but I cannot start any tests. When starting the test I get the following error:
|
if you added a tag annotation (like |
Support for mino and azurite is now included directly in transfer-05. In addition, the system test is now also implemented. Maybe changes are still necessary, e.g. the minio bucket could be created in a different way. If changes are still necessary, I could take care of this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool stuff!
transfer/transfer-05-file-transfer-cloud/cloud-transfer-consumer/config.properties
Outdated
Show resolved
Hide resolved
transfer/transfer-05-file-transfer-cloud/cloud-transfer-provider/config.properties
Outdated
Show resolved
Hide resolved
...em-tests/src/test/java/org/eclipse/edc/samples/transfer/Transfer05fileTransferCloudTest.java
Outdated
Show resolved
Hide resolved
...em-tests/src/test/java/org/eclipse/edc/samples/transfer/Transfer05fileTransferCloudTest.java
Outdated
Show resolved
Hide resolved
...em-tests/src/test/java/org/eclipse/edc/samples/transfer/Transfer05fileTransferCloudTest.java
Outdated
Show resolved
Hide resolved
…lt port fix and other small changes
I have edited the requested changes. I also made another change in system-test 05 because the wrong vault-port was used in the test. |
…#297) * add minio and azurite support to cloud sample * delete the vault connection on consumer side, since it is not needed * system test for transfer-05 added * minoi volume removed, bucket region changed and readme small change * readme changes, unnecessary configs removed, system-test-05 wrong vault port fix and other small changes * readme link to previous chapter fix * readme vault installation added
What this PR changes/adds
It changes the previous transfers so that a transfer between two docker containers is possible. A file is transferred from azurite to minio.
To start the containers, a docker-compose is used, which starts the containers on the necessary ports with the necessary login data. Here, azurite acts as the provider and minio as the consumer.
Once the containers have been started successfully, a blob storage is created using the Amazon CLI and the test-document is added to it.
The hashicorp-vault is used to store the login data. A vault server must be started manually and the keys added.
The azure-storage-dataplane is used to load the file from azurite, while the aws-s3-dataplane is used to send it to the consumer.
These changes have been added in a new module transfer-06-file-transfer-docker. The jsons for the transfer as well as the docker-compose and the test-document can be found in the resources folder.
Why it does that
For making the transfer-05 runnable without need for cloud accounts.
Further notes
In addition to the new module, a change has been made to the gradle/libs.version.toml file. The hashicorp vault dependency has been added here.
Linked Issue(s)
Closes #248