Skip to content

feat: add modbus-old schema validation to catalog workflow (#186) #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rohithgvmg wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: add modbus-old schema validation to catalog workflow (#186) #187

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbac30c
feat:added_modbus_old_validation
Rohithgvmg Jan 22, 2026
90e9585
style: fix code formatting issues
Rohithgvmg Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/components/Dialogs/ContributeToCatalogDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ const VALIDATION_TM_JSON =
"https://raw.githubusercontent.com/wot-oss/tmc/main/internal/commands/validate/tm-json-schema-validation.json";
const VALIDATION_MODBUS =
"https://raw.githubusercontent.com/wot-oss/tmc/refs/heads/main/internal/commands/validate/modbus.schema.json";
const VALIDATION_MODBUS_OLD =
"https://raw.githubusercontent.com/wot-oss/tmc/main/internal/commands/validate/modbus-old.schema.json";

const ContributeToCatalogDialog = forwardRef((props, ref) => {
const context = useContext(ediTDorContext);
Expand Down Expand Up @@ -286,6 +288,19 @@ const ContributeToCatalogDialog = forwardRef((props, ref) => {
throw new Error(message);
}

response = await fetch(VALIDATION_MODBUS_OLD);
if (!response.ok)
throw new Error(`Failed to fetch schema from ${VALIDATION_MODBUS_OLD}`);
schema = await response.json();
validate = ajv.compile(schema);
valid = validate(tdTransformed);
if (!valid) {
let message = `Validation failed for ${VALIDATION_MODBUS_OLD}: ${
validate.errors ? ajv.errorsText(validate.errors) : ""
}`;
throw new Error(message);
}

dispatch({ type: "SET_BACKGROUND_TD_TO_SEND", payload: tdTransformed });
dispatch({ type: "SET_METADATA_ERROR_MESSAGE", payload: "" });
dispatch({ type: "SET_METADATA_VALIDATION", payload: "VALID" });
Expand Down