refactored according to instructions#211
refactored according to instructions#211Rohithgvmg wants to merge 3 commits intoeclipse-editdor:masterfrom
Conversation
✅ Deploy Preview for editdor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Rohith <rgvmanikanta05@gmail.com>
Signed-off-by: Rohith <rgvmanikanta05@gmail.com>
|
dropdown component is not suitable, since it does not have react state handlers, unless the component itself is modified |
@Rohithgvmg You can change it. The intent is to be reusable in another places. Remember to test it in another places. There is an ongoing effort in refactoring all the code base. So all effort to split and make reusable components is good. If you see that the current dropdown component is affect to much by it you can do subcomponent that has the Dropdown in it and all the handlers logic can go into this subcomponent. Just an ideia. Drop the package-lock.json file you committed. we are using yarn as a package manager. |
Fixes #205