Add missing "static" modifier for constants

To reduce memory per instance
eclipse-equinox · Jun 8, 2023 · ab2268e · ab2268e
1 parent ba9f9bb
commit ab2268e
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/...e.equinox.p2.operations/src/org/eclipse/equinox/internal/p2/operations/RequestFlexer.java b/...e.equinox.p2.operations/src/org/eclipse/equinox/internal/p2/operations/RequestFlexer.java
@@ -27,10 +27,10 @@
 import org.eclipse.equinox.p2.query.*;
 
 public class RequestFlexer {
-	final String INCLUSION_RULES = "org.eclipse.equinox.p2.internal.inclusion.rules"; //$NON-NLS-1$
-	final String INCLUSION_OPTIONAL = "OPTIONAL"; //$NON-NLS-1$
-	final String INCLUSION_STRICT = "STRICT"; //$NON-NLS-1$
-	final String EXPLANATION_ENABLEMENT = "org.eclipse.equinox.p2.director.explain"; //$NON-NLS-1$
+	static final String INCLUSION_RULES = "org.eclipse.equinox.p2.internal.inclusion.rules"; //$NON-NLS-1$
+	static final String INCLUSION_OPTIONAL = "OPTIONAL"; //$NON-NLS-1$
+	static final String INCLUSION_STRICT = "STRICT"; //$NON-NLS-1$
+	static final String EXPLANATION_ENABLEMENT = "org.eclipse.equinox.p2.director.explain"; //$NON-NLS-1$
 
 	IPlanner planner;
 

diff --git a/...clipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/RemediationGroup.java b/...clipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/RemediationGroup.java
@@ -34,10 +34,10 @@
 import org.eclipse.swt.widgets.*;
 
 public class RemediationGroup {
-	final int ALLOWPARTIALINSTALL_INDEX = 0;
-	final int ALLOWDIFFERENTVERSION_INDEX = 1;
-	final int ALLOWINSTALLEDUPDATE_INDEX = 2;
-	final int ALLOWINSTALLEDREMOVAL_INDEX = 3;
+	static final int ALLOWPARTIALINSTALL_INDEX = 0;
+	static final int ALLOWDIFFERENTVERSION_INDEX = 1;
+	static final int ALLOWINSTALLEDUPDATE_INDEX = 2;
+	static final int ALLOWINSTALLEDREMOVAL_INDEX = 3;
 
 	private RemediationOperation remediationOperation;
 	Composite remediationComposite;

diff --git a/...ipse.equinox.p2.updatesite/src/org/eclipse/equinox/internal/p2/updatesite/SiteBundle.java b/...ipse.equinox.p2.updatesite/src/org/eclipse/equinox/internal/p2/updatesite/SiteBundle.java
@@ -31,7 +31,7 @@ public class SiteBundle {
 
 	private String os;
 	private String patch;
-	private final boolean resolved = false;
+	private static final boolean resolved = false;
 	private SiteModel site;
 	private String type;
 	private URL url;

diff --git a/...pse.equinox.p2.updatesite/src/org/eclipse/equinox/internal/p2/updatesite/SiteFeature.java b/...pse.equinox.p2.updatesite/src/org/eclipse/equinox/internal/p2/updatesite/SiteFeature.java
@@ -37,7 +37,7 @@ public class SiteFeature {
 
 	private String os;
 	private String patch;
-	private final boolean resolved = false;
+	private static final boolean resolved = false;
 	private SiteModel site;
 	private String type;
 	private URL url;