Add new method IQueryResult.stream() #312
Conversation
| @@ -8,4 +8,12 @@ | |||
| </message_arguments> | |||
| </filter> | |||
| </resource> | |||
| <resource path="src/org/eclipse/equinox/p2/query/IQueryResult.java" type="org.eclipse.equinox.p2.query.IQueryResult"> | |||
There was a problem hiding this comment.
IQueryResult is not marked with @noimplement/@noextend but I wonder if clients are really supposed to create own implementations?
There was a problem hiding this comment.
Tycho has some implementations of IQueryResult, I don't see why one should not allow this?
There was a problem hiding this comment.
People do what they're not supposed to do, so if they're allowed, one can assume that someone will to it. 😱
What about a default method that does toSet().stream() so that by default there is always an implementation?
There was a problem hiding this comment.
OK with custom queryable this makes sense.
Tycho even already has a stream() method in its own implementation, but it only needs to be made public when depending on the next Eclipse Release, so I think this is fine.
https://github.com/eclipse-tycho/tycho/blob/master/p2-maven-plugin/src/main/java/org/eclipse/tycho/p2maven/ListQueryable.java#L80-L83
There was a problem hiding this comment.
IQueryable already implements Iterable so using the iterator for default implementations seems a better choice to prevent creation of an intermediate set.
There was a problem hiding this comment.
What about a default method that does toSet().stream() so that by default there is always an implementation?
That's possible. But as Christoph suggested it could use the Spliterator of the IQueryResult, like it is currently done in QueryResult.
Iterable itself unfortunately does not provide a stream() method (if it would this PR would be pointless).
There was a problem hiding this comment.
What about a default method that does toSet().stream() so that by default there is always an implementation?
That's possible. But as Christoph suggested it could use the
Spliteratorof theIQueryResult, like it is currently done inQueryResult.
Done.
HannesWell
force-pushed
the
queryResultStream
branch
2 times, most recently
from
717690c
to
9a36ef7
Compare
HannesWell
force-pushed
the
queryResultStream
branch
from
9a36ef7
to
a55a707
Compare
This improves the interoperability of IQueryResult and Java's Stream-API.
HannesWell
force-pushed
the
queryResultStream
branch
from
a55a707
to
f507ce9
Compare
This improves the interoperability of
IQueryResultand the Java's modern Stream-API.Additionally Clean-up
IQueryResultand its implementations in a separate first commit.