Do content sensing to make sure the file is really not a jar #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we rely on the file-ending to determine the type of file but this can fail in cases a CacheManger returns a cached file without that extension (for whatever reason). This now adds another check for content sensing if the simple check fails to ensure a zipped item is not parsed as plain text.
|
Great so lets merge this after Eclipse Platform M2 promotion freeze is over... |
|
There is no freeze for m2. Just merge when ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we rely on the file-ending to determine the type of file but this can fail in cases a CacheManger returns a cached file without that extension (for whatever reason).
This now adds another check for content sensing if the simple check fails to ensure a zipped item is not parsed as plain text.