Provide RepositoryHelper.getSharedBundlePools() #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This returns shared bundle pools as used by the Eclipse Installer. eclipse-equinox#373
laeubi
reviewed
Nov 5, 2023
| @@ -31,7 +31,8 @@ Export-Package: org.eclipse.equinox.internal.p2.persistence; | |||
| org.eclipse.equinox.p2.publisher, | |||
| org.eclipse.equinox.p2.repository.tools, | |||
| org.eclipse.equinox.p2.ui, | |||
| org.eclipse.equinox.p2.updatesite", | |||
| org.eclipse.equinox.p2.updatesite, | |||
| org.eclipse.pde.core", | |||
HannesWell
reviewed
Nov 5, 2023
There was a problem hiding this comment.
Looks good to me.
I wonder are there already classes/packages in P2 dedicated to bundle-pooling? Or is a bundle pool for p2 simply a local repository?
The p2 wiki is not clear about this: https://wiki.eclipse.org/Equinox/p2/Getting_Started#Bundle_pooling
laeubi
reviewed
Nov 5, 2023
| * | ||
| * @return an unmodifiable list of global shared bundle pools. | ||
| * | ||
| * @throws IOException if there are problems loading the pool information. |
There was a problem hiding this comment.
On the long term I think we might simply return an empty list in such case?
There was a problem hiding this comment.
Yes, I wondered too about guarding all exceptions within the method....
HannesWell
approved these changes
Nov 5, 2023
laeubi
reviewed
Nov 5, 2023
| */ | ||
| @SuppressWarnings("nls") | ||
| public static List<Path> getSharedBundlePools() throws IOException { | ||
| Path bundlePools = Path.of(System.getProperty("user.home"), ".p2/pools.info"); |
There was a problem hiding this comment.
Feel free to improve things. This often happens because only touched lines are formatted, and I removed the if guard. Sorry about that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This returns shared bundle pools as used by the Eclipse Installer.
#373