Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use repo event method #511

Merged
merged 2 commits into from
May 11, 2024
Merged

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented May 11, 2024

No description provided.

Copy link

github-actions bot commented May 11, 2024

Test Results

  375 files  ±0    375 suites  ±0   40m 36s ⏱️ - 1m 38s
1 893 tests ±0  1 890 ✅ ±0  3 💤 ±0  0 ❌ ±0 
6 679 runs  ±0  6 670 ✅ ±0  9 💤 ±0  0 ❌ ±0 

Results for commit 5b8a245. ± Comparison against base commit fabf6d0.

♻️ This comment has been updated with latest results.

@laeubi laeubi force-pushed the use_repo_event_method branch 2 times, most recently from d7dcead to 6cd1b69 Compare May 11, 2024 06:07
Currently even if a reference would define a nickname it is not passed
by the repository event resulting in an updatesite to have an empty
name.

This uses the RepositoryEvent.newDiscoveryEvent(...) method to pass the
nickname is present.
Currently if a discovery event would define a nickname it is not passed
by the add repository method resulting in an updatesite to have an empty
name.

This adds a new method that allows to pass a custom RepositoryInfo so
the nickname can be set.
@laeubi laeubi merged commit 4ed9c3e into eclipse-equinox:master May 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant