-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify p2.tests.reconciler product #53
Simplify p2.tests.reconciler product #53
Conversation
6e5b0b9
to
00807e2
Compare
00807e2
to
5ffbcf7
Compare
Is this still relevant? |
@HannesWell I noticed that there is an "examples" folder, I think we should either delete or move products there it seems the products are not really build. Then there is also a tests.reconciler that also contains a product so it seems all a bit duplicated... If products are still build, we better should place them under "products/product_name" folder |
I think so.
I just created #114 to move all products (except for the test-product) to a |
This one needs manual rebase if still needed. |
@HannesWell is this still needed? |
5ffbcf7
to
a99da1a
Compare
Would be nice to have, yes to also have some 'real-life' test cases of mixed products. Given that the build succeeds, should we wait until eclipse-pde/eclipse.pde#291 is completed? I plan/hope to finish that soon. |
a99da1a
to
9705f46
Compare
9705f46
to
ac1e8be
Compare
What is the status of this one? It needs manual rebase at least. |
I will complete eclipse-pde/eclipse.pde#291 when back from vacation and will then take care of this. |
ac1e8be
to
a30d55c
Compare
85935f1
to
66b7484
Compare
Great. The build finally succeeded. |
Thanks @HannesWell ! I had to fix this product so many times over the years so I'm quite happy to see it so much simpler. |
The p2.tests.reconciler product can be simplified significantly if it is converted to be feature based.
But this requires a mixed product since no feature (except for the SDK) contains the
org.eclipse.equinox.p2.installer
plug-in, which seems to be necessary.At the moment this seems not to work (altough Tycho should support this). I will investigate it further when completing Bug 325614.