Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify p2.tests.reconciler product #53

Merged

Conversation

HannesWell
Copy link
Member

@HannesWell HannesWell commented Apr 30, 2022

The p2.tests.reconciler product can be simplified significantly if it is converted to be feature based.
But this requires a mixed product since no feature (except for the SDK) contains the org.eclipse.equinox.p2.installer plug-in, which seems to be necessary.

At the moment this seems not to work (altough Tycho should support this). I will investigate it further when completing Bug 325614.

@HannesWell HannesWell force-pushed the fixReconceilerTestProduct branch 5 times, most recently from 6e5b0b9 to 00807e2 Compare April 30, 2022 18:12
@HannesWell HannesWell changed the title Fix and simplify p2.tests.reconciler product Simplify p2.tests.reconciler product Apr 30, 2022
@HannesWell HannesWell marked this pull request as draft April 30, 2022 18:16
@laeubi
Copy link
Member

laeubi commented Jul 15, 2022

Is this still relevant?

@laeubi
Copy link
Member

laeubi commented Jul 16, 2022

@HannesWell I noticed that there is an "examples" folder, I think we should either delete or move products there it seems the products are not really build. Then there is also a tests.reconciler that also contains a product so it seems all a bit duplicated...

If products are still build, we better should place them under "products/product_name" folder

@HannesWell
Copy link
Member Author

Is this still relevant?

I think so.

@HannesWell I noticed that there is an "examples" folder, I think we should either delete or move products there it seems the products are not really build. Then there is also a tests.reconciler that also contains a product so it seems all a bit duplicated...

If products are still build, we better should place them under "products/product_name" folder

I just created #114 to move all products (except for the test-product) to a products folder.

@akurtakov
Copy link
Member

This one needs manual rebase if still needed.

@laeubi
Copy link
Member

laeubi commented Dec 3, 2022

@HannesWell is this still needed?

@HannesWell
Copy link
Member Author

@HannesWell is this still needed?

Would be nice to have, yes to also have some 'real-life' test cases of mixed products.

Given that the build succeeds, should we wait until eclipse-pde/eclipse.pde#291 is completed? I plan/hope to finish that soon.

@akurtakov
Copy link
Member

What is the status of this one? It needs manual rebase at least.

@HannesWell
Copy link
Member Author

What is the status of this one? It needs manual rebase at least.

I will complete eclipse-pde/eclipse.pde#291 when back from vacation and will then take care of this.

@github-actions
Copy link

github-actions bot commented Jun 18, 2023

Test Results

       9 files  ±0         9 suites  ±0   39m 12s ⏱️ + 5m 23s
2 176 tests ±0  2 172 ✔️ ±0    4 💤 ±0  0 ±0 
6 618 runs  ±0  6 607 ✔️ ±0  11 💤 ±0  0 ±0 

Results for commit 66b7484. ± Comparison against base commit 02f345d.

♻️ This comment has been updated with latest results.

@HannesWell HannesWell marked this pull request as ready for review July 17, 2023 23:06
@HannesWell
Copy link
Member Author

Great. The build finally succeeded.

@akurtakov
Copy link
Member

Thanks @HannesWell ! I had to fix this product so many times over the years so I'm quite happy to see it so much simpler.

@akurtakov akurtakov merged commit 2cb5b2c into eclipse-equinox:master Jul 18, 2023
@HannesWell HannesWell deleted the fixReconceilerTestProduct branch July 18, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants